Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove @fluentui/react-data-grid-react-window #28637

Conversation

layershifter
Copy link
Member

This packages was deprecated and is hosted now in contrib repo (https://github.com/microsoft/fluentui-contrib) under @fluentui-contrib/react-data-grid-react-window name.

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 77 76 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 601 591 5000
Button mount 297 300 5000
Field mount 1049 1057 5000
FluentProvider mount 650 661 5000
FluentProviderWithTheme mount 77 76 10 Possible regression
FluentProviderWithTheme virtual-rerender 63 76 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 66 10
InfoButton mount 11 16 5000
MakeStyles mount 873 879 50000
Persona mount 1663 1648 5000
SpinButton mount 1324 1335 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eedc58:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 84 71 1.18:1
AttachmentMinimalPerf.default 92 84 1.1:1
ButtonMinimalPerf.default 96 87 1.1:1
ButtonSlotsPerf.default 336 309 1.09:1
CarouselMinimalPerf.default 272 250 1.09:1
LayoutMinimalPerf.default 212 197 1.08:1
TreeWith60ListItems.default 94 87 1.08:1
GridMinimalPerf.default 199 186 1.07:1
ListNestedPerf.default 342 319 1.07:1
AlertMinimalPerf.default 167 158 1.06:1
BoxMinimalPerf.default 207 195 1.06:1
CardMinimalPerf.default 325 308 1.06:1
ReactionMinimalPerf.default 216 204 1.06:1
AvatarMinimalPerf.default 112 107 1.05:1
DropdownManyItemsPerf.default 403 382 1.05:1
ChatWithPopoverPerf.default 189 182 1.04:1
FormMinimalPerf.default 233 223 1.04:1
SliderMinimalPerf.default 762 732 1.04:1
AttachmentSlotsPerf.default 661 639 1.03:1
ChatDuplicateMessagesPerf.default 147 143 1.03:1
ToolbarMinimalPerf.default 554 537 1.03:1
ItemLayoutMinimalPerf.default 731 715 1.02:1
ListCommonPerf.default 401 394 1.02:1
SkeletonMinimalPerf.default 203 199 1.02:1
TextMinimalPerf.default 200 196 1.02:1
PortalMinimalPerf.default 82 81 1.01:1
ProviderMinimalPerf.default 206 203 1.01:1
SplitButtonMinimalPerf.default 2263 2249 1.01:1
StatusMinimalPerf.default 409 403 1.01:1
IconMinimalPerf.default 404 400 1.01:1
DatepickerMinimalPerf.default 3581 3579 1:1
DropdownMinimalPerf.default 1432 1437 1:1
HeaderSlotsPerf.default 466 464 1:1
LabelMinimalPerf.default 230 230 1:1
MenuMinimalPerf.default 502 501 1:1
ProviderMergeThemesPerf.default 670 668 1:1
RadioGroupMinimalPerf.default 265 264 1:1
TableMinimalPerf.default 242 242 1:1
CustomToolbarPrototype.default 1501 1496 1:1
TreeMinimalPerf.default 485 484 1:1
AnimationMinimalPerf.default 304 308 0.99:1
CheckboxMinimalPerf.default 1153 1159 0.99:1
EmbedMinimalPerf.default 1885 1897 0.99:1
InputMinimalPerf.default 541 544 0.99:1
MenuButtonMinimalPerf.default 971 984 0.99:1
TableManyItemsPerf.default 1124 1131 0.99:1
TextAreaMinimalPerf.default 305 308 0.99:1
TooltipMinimalPerf.default 1272 1280 0.99:1
DividerMinimalPerf.default 201 206 0.98:1
RosterPerf.default 1530 1555 0.98:1
PopupMinimalPerf.default 349 355 0.98:1
SegmentMinimalPerf.default 196 200 0.98:1
ChatMinimalPerf.default 429 441 0.97:1
DialogMinimalPerf.default 449 463 0.97:1
HeaderMinimalPerf.default 206 213 0.97:1
ListMinimalPerf.default 309 319 0.97:1
FlexMinimalPerf.default 149 155 0.96:1
RefMinimalPerf.default 109 113 0.96:1
ImageMinimalPerf.default 228 240 0.95:1
VideoMinimalPerf.default 417 437 0.95:1
ListWith60ListItems.default 352 377 0.93:1
LoaderMinimalPerf.default 186 199 0.93:1
ButtonOverridesMissPerf.default 647 707 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.383 kB
1.738 kB
react-accordion
Accordion (including children components)
88.535 kB
26.796 kB
react-alert
Alert
84.992 kB
22.03 kB
react-avatar
Avatar
47.739 kB
14.521 kB
react-avatar
AvatarGroup
15.695 kB
6.314 kB
react-avatar
AvatarGroupItem
63.915 kB
19.001 kB
react-badge
Badge
23.604 kB
7.272 kB
react-badge
CounterBadge
24.506 kB
7.574 kB
react-badge
PresenceBadge
22.253 kB
7.891 kB
react-button
Button
39.193 kB
9.743 kB
react-button
CompoundButton
46.661 kB
11.257 kB
react-button
MenuButton
43.553 kB
10.979 kB
react-button
SplitButton
51.758 kB
12.571 kB
react-button
ToggleButton
57.629 kB
11.645 kB
react-card
Card - All
89.609 kB
25.358 kB
react-card
Card
84.027 kB
23.768 kB
react-card
CardFooter
9.24 kB
3.907 kB
react-card
CardHeader
11.652 kB
4.741 kB
react-card
CardPreview
10.048 kB
4.254 kB
react-checkbox
Checkbox
33.224 kB
10.727 kB
react-combobox
Combobox (including child components)
87.395 kB
28.184 kB
react-combobox
Dropdown (including child components)
85.798 kB
27.804 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.576 kB
18.225 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.472 kB
57.814 kB
react-components
react-components: FluentProvider & webLightTheme
36.409 kB
12.003 kB
react-datepicker-compat
DatePicker Compat
217.582 kB
58.025 kB
react-dialog
Dialog (including children components)
87.367 kB
26.408 kB
react-divider
Divider
17.49 kB
6.364 kB
react-field
Field
18.174 kB
6.977 kB
react-image
Image
11.561 kB
4.637 kB
react-infobutton
InfoButton
126.163 kB
39.164 kB
react-infobutton
InfoLabel
129.763 kB
40.304 kB
react-input
Input
24.232 kB
7.781 kB
react-label
Label
10.186 kB
4.253 kB
react-link
Link
12.782 kB
5.247 kB
react-menu
Menu (including children components)
135.5 kB
41.325 kB
react-menu
Menu (including selectable components)
138.264 kB
41.828 kB
react-overflow
hooks only
12.64 kB
4.689 kB
react-persona
Persona
55.293 kB
16.535 kB
react-popover
Popover
114.722 kB
35.751 kB
react-portal
Portal
11.935 kB
4.421 kB
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
react-positioning
usePositioning
24.468 kB
8.915 kB
react-progress
ProgressBar
13.941 kB
5.498 kB
react-provider
FluentProvider
18.129 kB
6.73 kB
react-radio
Radio
27.017 kB
8.638 kB
react-radio
RadioGroup
11.376 kB
4.763 kB
react-select
Select
24.955 kB
8.722 kB
react-slider
Slider
34.87 kB
11.178 kB
react-spinbutton
SpinButton
33.756 kB
10.35 kB
react-spinner
Spinner
21.77 kB
7.134 kB
react-switch
Switch
29.511 kB
9.239 kB
react-table
DataGrid
158.464 kB
42.465 kB
react-table
Table (Primitives only)
43.95 kB
12.263 kB
react-table
Table as DataGrid
132.268 kB
33.902 kB
react-table
Table (Selection only)
77.643 kB
19.195 kB
react-table
Table (Sort only)
76.262 kB
18.798 kB
react-tags-preview
InteractionTag
34.171 kB
9.199 kB
react-tags-preview
Tag
25.962 kB
8.49 kB
react-tags-preview
TagGroup
69.398 kB
20.364 kB
react-text
Text - Default
12.574 kB
4.982 kB
react-text
Text - Wrappers
15.726 kB
5.302 kB
react-textarea
Textarea
27.703 kB
9.126 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.987 kB
6.85 kB
react-theme
Teams: Light theme
18.121 kB
5.194 kB
react-toast
Toast (including Toaster)
78.573 kB
23.728 kB
react-tooltip
Tooltip
47.659 kB
16.697 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 8959c81f6a2ef8637a4a7d7dd8b67bd40aa64cd6

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

🕵 FluentUIV0 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Jul 25, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8959c81f6a2ef8637a4a7d7dd8b67bd40aa64cd6 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 25, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 629 649 5000
Breadcrumb mount 1723 1703 1000
Checkbox mount 1700 1693 5000
CheckboxBase mount 1487 1500 5000
ChoiceGroup mount 2978 2976 5000
ComboBox mount 648 678 1000
CommandBar mount 6272 6263 1000
ContextualMenu mount 14296 14019 1000
DefaultButton mount 756 757 5000
DetailsRow mount 2188 2177 5000
DetailsRowFast mount 2184 2193 5000
DetailsRowNoStyles mount 1926 2005 5000
Dialog mount 2751 2728 1000
DocumentCardTitle mount 231 231 1000
Dropdown mount 2004 1976 5000
FocusTrapZone mount 1118 1126 5000
FocusZone mount 1056 1068 5000
GroupedList mount 41030 41382 2
GroupedList virtual-rerender 19947 19826 2
GroupedList virtual-rerender-with-unmount 55205 50593 2
GroupedListV2 mount 218 228 2
GroupedListV2 virtual-rerender 195 213 2
GroupedListV2 virtual-rerender-with-unmount 220 218 2
IconButton mount 1090 1062 5000
Label mount 323 339 5000
Layer mount 2744 2727 5000
Link mount 390 389 5000
MenuButton mount 937 895 5000
MessageBar mount 21410 21482 5000
Nav mount 1976 1958 1000
OverflowSet mount 786 781 5000
Panel mount 1785 1767 1000
Persona mount 742 756 1000
Pivot mount 875 864 1000
PrimaryButton mount 858 835 5000
Rating mount 4558 4693 5000
SearchBox mount 902 895 5000
Shimmer mount 1933 1891 5000
Slider mount 1340 1345 5000
SpinButton mount 2895 2858 5000
Spinner mount 380 390 5000
SplitButton mount 1843 1802 5000
Stack mount 408 415 5000
StackWithIntrinsicChildren mount 857 853 5000
StackWithTextChildren mount 2653 2618 5000
SwatchColorPicker mount 6066 6107 5000
TagPicker mount 1438 1509 5000
Text mount 375 366 5000
TextField mount 922 944 5000
ThemeProvider mount 848 819 5000
ThemeProvider virtual-rerender 586 611 5000
ThemeProvider virtual-rerender-with-unmount 1242 1275 5000
Toggle mount 616 623 5000
buttonNative mount 186 192 5000

@layershifter layershifter force-pushed the chore/remove-react-data-grid-react-window branch from 2375c73 to 5eedc58 Compare July 25, 2023 20:37
@layershifter layershifter enabled auto-merge (squash) July 25, 2023 20:38
@layershifter layershifter merged commit dab84e1 into microsoft:master Jul 25, 2023
@layershifter layershifter deleted the chore/remove-react-data-grid-react-window branch July 26, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants