-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove @fluentui/react-data-grid-react-window #28637
Merged
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/remove-react-data-grid-react-window
Jul 25, 2023
Merged
chore: remove @fluentui/react-data-grid-react-window #28637
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/remove-react-data-grid-react-window
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
July 25, 2023 14:52
ling1726
approved these changes
Jul 25, 2023
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | mount | 77 | 76 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 601 | 591 | 5000 | |
Button | mount | 297 | 300 | 5000 | |
Field | mount | 1049 | 1057 | 5000 | |
FluentProvider | mount | 650 | 661 | 5000 | |
FluentProviderWithTheme | mount | 77 | 76 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender | 63 | 76 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 66 | 10 | |
InfoButton | mount | 11 | 16 | 5000 | |
MakeStyles | mount | 873 | 879 | 50000 | |
Persona | mount | 1663 | 1648 | 5000 | |
SpinButton | mount | 1324 | 1335 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5eedc58:
|
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
AccordionMinimalPerf.default | 84 | 71 | 1.18:1 |
AttachmentMinimalPerf.default | 92 | 84 | 1.1:1 |
ButtonMinimalPerf.default | 96 | 87 | 1.1:1 |
ButtonSlotsPerf.default | 336 | 309 | 1.09:1 |
CarouselMinimalPerf.default | 272 | 250 | 1.09:1 |
LayoutMinimalPerf.default | 212 | 197 | 1.08:1 |
TreeWith60ListItems.default | 94 | 87 | 1.08:1 |
GridMinimalPerf.default | 199 | 186 | 1.07:1 |
ListNestedPerf.default | 342 | 319 | 1.07:1 |
AlertMinimalPerf.default | 167 | 158 | 1.06:1 |
BoxMinimalPerf.default | 207 | 195 | 1.06:1 |
CardMinimalPerf.default | 325 | 308 | 1.06:1 |
ReactionMinimalPerf.default | 216 | 204 | 1.06:1 |
AvatarMinimalPerf.default | 112 | 107 | 1.05:1 |
DropdownManyItemsPerf.default | 403 | 382 | 1.05:1 |
ChatWithPopoverPerf.default | 189 | 182 | 1.04:1 |
FormMinimalPerf.default | 233 | 223 | 1.04:1 |
SliderMinimalPerf.default | 762 | 732 | 1.04:1 |
AttachmentSlotsPerf.default | 661 | 639 | 1.03:1 |
ChatDuplicateMessagesPerf.default | 147 | 143 | 1.03:1 |
ToolbarMinimalPerf.default | 554 | 537 | 1.03:1 |
ItemLayoutMinimalPerf.default | 731 | 715 | 1.02:1 |
ListCommonPerf.default | 401 | 394 | 1.02:1 |
SkeletonMinimalPerf.default | 203 | 199 | 1.02:1 |
TextMinimalPerf.default | 200 | 196 | 1.02:1 |
PortalMinimalPerf.default | 82 | 81 | 1.01:1 |
ProviderMinimalPerf.default | 206 | 203 | 1.01:1 |
SplitButtonMinimalPerf.default | 2263 | 2249 | 1.01:1 |
StatusMinimalPerf.default | 409 | 403 | 1.01:1 |
IconMinimalPerf.default | 404 | 400 | 1.01:1 |
DatepickerMinimalPerf.default | 3581 | 3579 | 1:1 |
DropdownMinimalPerf.default | 1432 | 1437 | 1:1 |
HeaderSlotsPerf.default | 466 | 464 | 1:1 |
LabelMinimalPerf.default | 230 | 230 | 1:1 |
MenuMinimalPerf.default | 502 | 501 | 1:1 |
ProviderMergeThemesPerf.default | 670 | 668 | 1:1 |
RadioGroupMinimalPerf.default | 265 | 264 | 1:1 |
TableMinimalPerf.default | 242 | 242 | 1:1 |
CustomToolbarPrototype.default | 1501 | 1496 | 1:1 |
TreeMinimalPerf.default | 485 | 484 | 1:1 |
AnimationMinimalPerf.default | 304 | 308 | 0.99:1 |
CheckboxMinimalPerf.default | 1153 | 1159 | 0.99:1 |
EmbedMinimalPerf.default | 1885 | 1897 | 0.99:1 |
InputMinimalPerf.default | 541 | 544 | 0.99:1 |
MenuButtonMinimalPerf.default | 971 | 984 | 0.99:1 |
TableManyItemsPerf.default | 1124 | 1131 | 0.99:1 |
TextAreaMinimalPerf.default | 305 | 308 | 0.99:1 |
TooltipMinimalPerf.default | 1272 | 1280 | 0.99:1 |
DividerMinimalPerf.default | 201 | 206 | 0.98:1 |
RosterPerf.default | 1530 | 1555 | 0.98:1 |
PopupMinimalPerf.default | 349 | 355 | 0.98:1 |
SegmentMinimalPerf.default | 196 | 200 | 0.98:1 |
ChatMinimalPerf.default | 429 | 441 | 0.97:1 |
DialogMinimalPerf.default | 449 | 463 | 0.97:1 |
HeaderMinimalPerf.default | 206 | 213 | 0.97:1 |
ListMinimalPerf.default | 309 | 319 | 0.97:1 |
FlexMinimalPerf.default | 149 | 155 | 0.96:1 |
RefMinimalPerf.default | 109 | 113 | 0.96:1 |
ImageMinimalPerf.default | 228 | 240 | 0.95:1 |
VideoMinimalPerf.default | 417 | 437 | 0.95:1 |
ListWith60ListItems.default | 352 | 377 | 0.93:1 |
LoaderMinimalPerf.default | 186 | 199 | 0.93:1 |
ButtonOverridesMissPerf.default | 647 | 707 | 0.92:1 |
🕵 fluentuiv8 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8959c81f6a2ef8637a4a7d7dd8b67bd40aa64cd6 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 629 | 649 | 5000 | |
Breadcrumb | mount | 1723 | 1703 | 1000 | |
Checkbox | mount | 1700 | 1693 | 5000 | |
CheckboxBase | mount | 1487 | 1500 | 5000 | |
ChoiceGroup | mount | 2978 | 2976 | 5000 | |
ComboBox | mount | 648 | 678 | 1000 | |
CommandBar | mount | 6272 | 6263 | 1000 | |
ContextualMenu | mount | 14296 | 14019 | 1000 | |
DefaultButton | mount | 756 | 757 | 5000 | |
DetailsRow | mount | 2188 | 2177 | 5000 | |
DetailsRowFast | mount | 2184 | 2193 | 5000 | |
DetailsRowNoStyles | mount | 1926 | 2005 | 5000 | |
Dialog | mount | 2751 | 2728 | 1000 | |
DocumentCardTitle | mount | 231 | 231 | 1000 | |
Dropdown | mount | 2004 | 1976 | 5000 | |
FocusTrapZone | mount | 1118 | 1126 | 5000 | |
FocusZone | mount | 1056 | 1068 | 5000 | |
GroupedList | mount | 41030 | 41382 | 2 | |
GroupedList | virtual-rerender | 19947 | 19826 | 2 | |
GroupedList | virtual-rerender-with-unmount | 55205 | 50593 | 2 | |
GroupedListV2 | mount | 218 | 228 | 2 | |
GroupedListV2 | virtual-rerender | 195 | 213 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 220 | 218 | 2 | |
IconButton | mount | 1090 | 1062 | 5000 | |
Label | mount | 323 | 339 | 5000 | |
Layer | mount | 2744 | 2727 | 5000 | |
Link | mount | 390 | 389 | 5000 | |
MenuButton | mount | 937 | 895 | 5000 | |
MessageBar | mount | 21410 | 21482 | 5000 | |
Nav | mount | 1976 | 1958 | 1000 | |
OverflowSet | mount | 786 | 781 | 5000 | |
Panel | mount | 1785 | 1767 | 1000 | |
Persona | mount | 742 | 756 | 1000 | |
Pivot | mount | 875 | 864 | 1000 | |
PrimaryButton | mount | 858 | 835 | 5000 | |
Rating | mount | 4558 | 4693 | 5000 | |
SearchBox | mount | 902 | 895 | 5000 | |
Shimmer | mount | 1933 | 1891 | 5000 | |
Slider | mount | 1340 | 1345 | 5000 | |
SpinButton | mount | 2895 | 2858 | 5000 | |
Spinner | mount | 380 | 390 | 5000 | |
SplitButton | mount | 1843 | 1802 | 5000 | |
Stack | mount | 408 | 415 | 5000 | |
StackWithIntrinsicChildren | mount | 857 | 853 | 5000 | |
StackWithTextChildren | mount | 2653 | 2618 | 5000 | |
SwatchColorPicker | mount | 6066 | 6107 | 5000 | |
TagPicker | mount | 1438 | 1509 | 5000 | |
Text | mount | 375 | 366 | 5000 | |
TextField | mount | 922 | 944 | 5000 | |
ThemeProvider | mount | 848 | 819 | 5000 | |
ThemeProvider | virtual-rerender | 586 | 611 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1242 | 1275 | 5000 | |
Toggle | mount | 616 | 623 | 5000 | |
buttonNative | mount | 186 | 192 | 5000 |
JustSlone
approved these changes
Jul 25, 2023
layershifter
force-pushed
the
chore/remove-react-data-grid-react-window
branch
from
July 25, 2023 20:37
2375c73
to
5eedc58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This packages was deprecated and is hosted now in contrib repo (https://github.com/microsoft/fluentui-contrib) under
@fluentui-contrib/react-data-grid-react-window
name.