fix: MenuDivider thickness should be strokeWidthThin
#25711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the border style of `MenuDivider` to use `strokeWidthThin` design token
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d2a957c632af5cc995b4582a3b8e8f075139df7b (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1298 | 1265 | 5000 | |
| Button | mount | 903 | 931 | 5000 | |
| FluentProvider | mount | 1478 | 1479 | 5000 | |
| FluentProviderWithTheme | mount | 566 | 585 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 535 | 543 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 571 | 580 | 10 | |
| MakeStyles | mount | 1967 | 1963 | 50000 | |
| SpinButton | mount | 2373 | 2295 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8cf400:
|
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
layershifter
approved these changes
Nov 22, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* fix: MenuDivider thickness should be `strokeWidthThin` Updates the border style of `MenuDivider` to use `strokeWidthThin` design token * changefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the border style of
MenuDividerto usestrokeWidthThindesign token