Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

dzearing · 2022-11-05T01:18:49Z

Repro

Using esbuild, bundle @fluentui/react/lib/index.js with esbuild, but externalize date-time-utilities.
Try to import DayOfWeek from bundle.

Current Behavior

It's not exported because there are multiple paths to the external library, and esbuild gives up trying to dedupe across external boundaries.

New Behavior

Due to expanding the root barrel index.ts star exports, paths to the exported things are now straightened out and you can now import DayOfWeek from the resulting bundle.

Notes

The api extractor result validated no api shift
There were a number of duplicates in the exports that I removed by manually removing red squiggles.
It is possible but very unlikely that importing {namedThing} from './SomeTopLevelThing' could translate to more nested export * ambiguity deeper int the tree, without getting rid of all export *s in sub-level barrel files. I'm minimizing the change here, and so far I don't see a need to go beyond the root. In v9 hopefully export * is totally disallowed, because it causes problems downstream. Better to be explicit.

Related Issue(s)

See issue: evanw/esbuild#2658

size-auditor · 2022-11-05T01:30:45Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 65b289ef0e47b684365058f16b50587a5fae8633 (build)

codesandbox-ci · 2022-11-05T01:32:00Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4474f53:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-05T01:33:06Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.284 kB` `24.446 kB`
`react-alert` Alert	`84.771 kB` `21.265 kB`
`react-avatar` Avatar	`48.956 kB` `13.883 kB`
`react-avatar` AvatarGroup	`14.996 kB` `6.013 kB`
`react-avatar` AvatarGroupItem	`63.534 kB` `17.979 kB`
`react-badge` Badge	`22.646 kB` `7.228 kB`
`react-badge` CounterBadge	`23.536 kB` `7.512 kB`
`react-badge` PresenceBadge	`24.096 kB` `7.09 kB`
`react-button` Button	`36.85 kB` `9.917 kB`
`react-button` CompoundButton	`43.875 kB` `11.134 kB`
`react-button` MenuButton	`39.544 kB` `10.816 kB`
`react-button` SplitButton	`46.99 kB` `12.201 kB`
`react-button` ToggleButton	`52.535 kB` `11.4 kB`
`react-card` Card - All	`71.863 kB` `20.939 kB`
`react-card` Card	`67.641 kB` `19.897 kB`
`react-card` CardFooter	`8.607 kB` `3.622 kB`
`react-card` CardHeader	`9.782 kB` `3.998 kB`
`react-card` CardPreview	`8.708 kB` `3.678 kB`
`react-combobox` Combobox (including child components)	`76.153 kB` `24.665 kB`
`react-combobox` Dropdown (including child components)	`75.885 kB` `24.635 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.941 kB` `17.678 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`189.948 kB` `52.993 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.446 kB` `11.033 kB`
`react-dialog` Dialog (including children components)	`83.147 kB` `24.799 kB`
`react-divider` Divider	`16.505 kB` `5.925 kB`
`react-image` Image	`10.826 kB` `4.286 kB`
`react-infobutton` InfoButton	`112.443 kB` `34.387 kB`
`react-input` Input	`24.428 kB` `7.899 kB`
`react-label` Label	`9.384 kB` `3.883 kB`
`react-link` Link	`11.852 kB` `4.888 kB`
`react-menu` Menu (including children components)	`117.131 kB` `36.2 kB`
`react-menu` Menu (including selectable components)	`120.2 kB` `36.726 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`54.074 kB` `15.269 kB`
`react-popover` Popover	`103.672 kB` `31.871 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.526 kB` `5.113 kB`
`react-provider` FluentProvider	`15.807 kB` `5.909 kB`
`react-radio` Radio	`36.436 kB` `12.126 kB`
`react-radio` RadioGroup	`14.294 kB` `5.723 kB`
`react-select` Select	`23.255 kB` `7.954 kB`
`react-slider` Slider	`32.108 kB` `10.195 kB`
`react-spinbutton` SpinButton	`45.826 kB` `12.858 kB`
`react-spinner` Spinner	`20.003 kB` `6.449 kB`
`react-switch` Switch	`33.443 kB` `10.585 kB`
`react-text` Text - Default	`11.828 kB` `4.627 kB`
`react-text` Text - Wrappers	`15.138 kB` `5.064 kB`
`react-textarea` Textarea	`25.687 kB` `8.331 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 65b289ef0e47b684365058f16b50587a5fae8633}

fabricteam · 2022-11-05T01:51:25Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1182	1177	5000
Breadcrumb	mount	2801	2762	1000
Checkbox	mount	2646	2644	5000
CheckboxBase	mount	2368	2368	5000
ChoiceGroup	mount	4308	4304	5000
ComboBox	mount	1169	1181	1000
CommandBar	mount	9229	9242	1000
ContextualMenu	mount	10032	10056	1000
DefaultButton	mount	1349	1353	5000
DetailsRow	mount	3385	3335	5000
DetailsRowFast	mount	3377	3343	5000
DetailsRowNoStyles	mount	3252	3245	5000
Dialog	mount	2919	2967	1000
DocumentCardTitle	mount	580	586	1000
Dropdown	mount	3171	3150	5000
FocusTrapZone	mount	1973	1986	5000
FocusZone	mount	1923	1937	5000
GroupedList	mount	1810	2048	2
GroupedList	virtual-rerender	1103	1100	2
GroupedList	virtual-rerender-with-unmount	1589	1579	2
GroupedListV2	mount	571	547	2
GroupedListV2	virtual-rerender	524	544	2
GroupedListV2	virtual-rerender-with-unmount	557	571	2
IconButton	mount	1784	1813	5000
Label	mount	747	762	5000
Layer	mount	4206	4154	5000
Link	mount	860	874	5000
MenuButton	mount	1628	1623	5000
MessageBar	mount	2394	2315	5000
Nav	mount	3081	3061	1000
OverflowSet	mount	1420	1429	5000
Panel	mount	2498	2531	1000
Persona	mount	1261	1265	1000
Pivot	mount	1503	1518	1000
PrimaryButton	mount	1476	1487	5000
Rating	mount	6973	6978	5000
SearchBox	mount	1481	1488	5000
Shimmer	mount	2900	2937	5000
Slider	mount	2109	2112	5000
SpinButton	mount	4390	4278	5000
Spinner	mount	821	821	5000
SplitButton	mount	2833	2855	5000
Stack	mount	865	871	5000
StackWithIntrinsicChildren	mount	2363	2346	5000
StackWithTextChildren	mount	5028	5058	5000
SwatchColorPicker	mount	9481	9423	5000
TagPicker	mount	2359	2384	5000
TeachingBubble	mount	73698	73706	5000
Text	mount	823	815	5000
TextField	mount	1551	1541	5000
ThemeProvider	mount	1450	1458	5000
ThemeProvider	virtual-rerender	1134	1135	5000
ThemeProvider	virtual-rerender-with-unmount	1998	1990	5000
Toggle	mount	1109	1132	5000
buttonNative	mount	545	530	5000

spmonahan · 2022-11-07T16:04:01Z

In v9 hopefully export * is totally disallowed, because it causes problems downstream. Better to be explicit.

I believe this is done in v9. See #22099

JasonGore · 2022-11-07T16:29:52Z

no-restricted-syntax eslint rule can help enforce this with ['error', 'ExportAllDeclaration'] configuration

Hotell · 2022-11-07T17:24:01Z

no-restricted-syntax eslint rule can help enforce this with ['error', 'ExportAllDeclaration'] configuration

while that might work the DX would far from ideal. we have rule for this.

I'd suggest to enable similar to base-legacy config @dzearing

https://github.com/microsoft/fluentui/blob/master/packages/eslint-plugin/src/configs/base.js#L17-L24

Hotell

following things need to be adressed before merging:

eslint plugin config needed
proper resolution of deprecation lints

packages/react/src/index.ts

dzearing · 2022-11-07T17:47:49Z

Updated react-legacy lint config to set export * to warn.

fabricteam · 2022-11-07T18:08:12Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1280	1277	5000
Button	mount	915	924	5000
FluentProvider	mount	1466	1495	5000
FluentProviderWithTheme	mount	573	583	10
FluentProviderWithTheme	virtual-rerender	536	543	10
FluentProviderWithTheme	virtual-rerender-with-unmount	572	586	10
MakeStyles	mount	1925	1945	50000
SpinButton	mount	2327	2352	5000

fabricteam · 2022-11-07T18:10:09Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
SkeletonMinimalPerf.default	318	291	1.09:1
FormMinimalPerf.default	345	321	1.07:1
TreeWith60ListItems.default	134	127	1.06:1
TextMinimalPerf.default	314	299	1.05:1
ButtonMinimalPerf.default	142	137	1.04:1
HeaderMinimalPerf.default	324	313	1.04:1
LabelMinimalPerf.default	349	335	1.04:1
PortalMinimalPerf.default	147	142	1.04:1
ReactionMinimalPerf.default	339	325	1.04:1
CarouselMinimalPerf.default	368	356	1.03:1
RadioGroupMinimalPerf.default	403	393	1.03:1
SegmentMinimalPerf.default	314	306	1.03:1
SliderMinimalPerf.default	1262	1230	1.03:1
TextAreaMinimalPerf.default	426	413	1.03:1
VideoMinimalPerf.default	623	607	1.03:1
AvatarMinimalPerf.default	168	165	1.02:1
ButtonOverridesMissPerf.default	1044	1028	1.02:1
ChatDuplicateMessagesPerf.default	222	218	1.02:1
DividerMinimalPerf.default	317	311	1.02:1
DropdownManyItemsPerf.default	554	542	1.02:1
LayoutMinimalPerf.default	318	311	1.02:1
LoaderMinimalPerf.default	267	261	1.02:1
MenuMinimalPerf.default	748	733	1.02:1
PopupMinimalPerf.default	574	563	1.02:1
ProviderMinimalPerf.default	331	323	1.02:1
BoxMinimalPerf.default	302	298	1.01:1
ChatMinimalPerf.default	653	649	1.01:1
DropdownMinimalPerf.default	2210	2187	1.01:1
EmbedMinimalPerf.default	2675	2650	1.01:1
FlexMinimalPerf.default	255	253	1.01:1
ListWith60ListItems.default	506	502	1.01:1
RosterPerf.default	1737	1718	1.01:1
RefMinimalPerf.default	191	189	1.01:1
TableManyItemsPerf.default	1610	1597	1.01:1
CustomToolbarPrototype.default	2263	2250	1.01:1
ToolbarMinimalPerf.default	808	798	1.01:1
ButtonSlotsPerf.default	431	432	1:1
CardMinimalPerf.default	469	470	1:1
CheckboxMinimalPerf.default	1548	1541	1:1
DialogMinimalPerf.default	696	697	1:1
HeaderSlotsPerf.default	680	680	1:1
InputMinimalPerf.default	862	862	1:1
ListNestedPerf.default	474	472	1:1
ProviderMergeThemesPerf.default	1007	1012	1:1
SplitButtonMinimalPerf.default	3307	3303	1:1
StatusMinimalPerf.default	618	616	1:1
TooltipMinimalPerf.default	1925	1923	1:1
AnimationMinimalPerf.default	470	473	0.99:1
AttachmentSlotsPerf.default	870	877	0.99:1
DatepickerMinimalPerf.default	4984	5032	0.99:1
ImageMinimalPerf.default	348	352	0.99:1
ListMinimalPerf.default	465	470	0.99:1
MenuButtonMinimalPerf.default	1385	1395	0.99:1
TreeMinimalPerf.default	710	714	0.99:1
AlertMinimalPerf.default	227	232	0.98:1
ItemLayoutMinimalPerf.default	970	992	0.98:1
ListCommonPerf.default	518	527	0.98:1
IconMinimalPerf.default	567	576	0.98:1
TableMinimalPerf.default	359	365	0.98:1
AttachmentMinimalPerf.default	125	129	0.97:1
GridMinimalPerf.default	293	301	0.97:1
ChatWithPopoverPerf.default	294	305	0.96:1
AccordionMinimalPerf.default	124	135	0.92:1

GeoffCoxMSFT · 2022-11-07T19:23:37Z

Will this break folks who may have specific imports to specify which export they depend on? I've seen some partners with specific esbuild config to resolve import issues and wonder if they will need to delete their workaround.

dzearing · 2022-11-07T20:10:28Z

@GeoffCoxMSFT I don't see this affecting anything with specific imports. It only affects the root index, and even then should not change any api surface.

Before:
Root index exports * from foo.js and bar.js with both export "baz" from "baz.js"

After:
Root index export { baz } from foo.js (pick one path)

Does not affect top-level export files at all.

Hotell · 2022-11-08T08:44:00Z

packages/eslint-plugin/src/configs/react-legacy.js

@@ -10,4 +10,13 @@ module.exports = {
    'jsdoc/check-tag-names': 'off',
    '@griffel/no-shorthands': 'off',
  },
+  overrides: [


this should go to configs/base-legacy.js as it has nothing specific with react

Hotell

one more change needed

config in packages/eslint-plugin/src/configs/react-legacy.js should go to packages/eslint-plugin/src/configs/base-legacy.js.

ty!

* stress-test: add "afterframe" dependency (microsoft#25560) Previously stress-test used a "requestPostAnimationFrame" function that is used to measure from just before style recalc, layout and paint are executed to just afterward. This change drops that function in favor of taking a dependency on afterframe, a library that does the same thing. * Fix: Update tabs to remain the same size between unselected and selected states (microsoft#25542) * Add support to keep tabs from changing size when selected * Update for naming and tests * Rename update * Update packages/react-components/react-tabs/src/components/TabList/TabList.types.ts Co-authored-by: Sean Monahan <[email protected]> Co-authored-by: Sean Monahan <[email protected]> * chore: Add reduced-motion documentation to Spinner (microsoft#25561) * chore: Add reduced-motion documentation to Spinner * change file * chore: Add documentation to Progress about reduced-motion (microsoft#25563) * chore: Add documentation to Progress about reduced-motion * change file * stress-test: disable CSS transitions on injected styles (microsoft#25559) This addresses an issue where Firefox's style recalculation measurement becomes unstable when controls under test have CSS transitions. Specifically, our test injects styles that update the background color of selected controls and many Fluent controls transition the background color for different states like "hover" and "focus". With transitions running Firefox will sometimes include the transition time in the style recalc measurement and sometimes not. Additionally, Chromium browsers never include the transition time in the measurement. Disabling transitions ensures measurement behavior is consistent in Firefox and in alignment with the behavior of Chromium browsers. * docs(rfcs): add triage automation rfc (microsoft#24817) * chore: update beachball ignore list to apply to new project structure (microsoft#25531) * bugfix(react-switch): adds line-height=0 to switch indicator slot (microsoft#25507) * chore: add both options to useArrowNavigationGroup (microsoft#25568) * chore: add both options to useArrowNavigationGroup * chore: add changes * chore: update api * chore(vr-tests-v9): Convert Dialog and Image VR tests to CSF (microsoft#25527) * chore: toolbar a11y improvements (microsoft#25562) * feat: create vertical example * chore: add navigation arrows for vertical scenario * chore: add labels for all toolbar stories * chore: update tooltip example * chore: update radio example * chore: update toolbar stories examples * chore: add changes * chore: use both in toolbar arrow key nav * chore: update snapshot * chore(react-dialog): migrate to new package structure (microsoft#25523) Co-authored-by: Oleksandr Fediashov <[email protected]> * chore(react-overflow): migrate to new package structure (microsoft#25524) * Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. (microsoft#25545) * expanding index. * change. * Replacing with inline deprecation exclusions. * setting export * to warning. * change. * moving rules around. * fix: v9 form controls with underline should have underline-specific disabled styling (microsoft#25543) Updates disabled form styling for Input, Select, Spinbutton, Combobox, and Dropdown * docs(public-docsite-v9): Adding a basic setup section to the SSR docs (microsoft#25564) * applying package updates * update regex * updatE * Update azure-pipelines.vrt-baseline.yml for Azure Pipelines * Update azure-pipelines.vrt-baseline.yml for Azure Pipelines * chore(deps): bump loader-utils from 2.0.0 to 2.0.3 (microsoft#25567) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.0 to 2.0.3. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.3/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.0...v2.0.3) --- updated-dependencies: - dependency-name: loader-utils dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: migrate @types/node to 14 to align with our supported node version (microsoft#25510) * chore(deps): resolve only to 1 @types/node version to mitigate global leaks and api-generation errors * fix(bundle-size): fix type errors exposed by node 14 typings * fix(tools): fix type errors exposed by node 14 typings * fix(typings): fix type errors exposed by node 14 typings * revert: use resolution for @types/node * chore(ts-minbar-test-react): use @types/node 14 explicitly * generate changefiles * chore: dedupe deps * fix(scripts): fix type errors exposed by node 14 typings * test: replace deprecated module.parent with require.main within isConformance * generate changefiles * test(react): clean up persona-coin test and use isConformant without side-effects * fix(storybook): fix theme picker current selection (microsoft#25533) * update * chore(vr-tests-v9): Convert Accordion VR tests to CSF (microsoft#25525) * fix: Update Avatar active ring color to match base color (microsoft#25497) * RFC: Field Package Layout (microsoft#25380) * Feature: Added large tab size to react-tabs (microsoft#25577) * Added large tab size * yarn change * Update vr-tests * Code review fix * feat(react-infobutton): Adding size prop, HCM styles, and updating styles to match design spec (microsoft#25519) * updating styles and adding size prop * updating comment * adding requested changes * fix: Adding expanded styles for MenuButtons and making various other styling fixes for Button components (microsoft#25521) * fix: Adding expanded styles for MenuButtons and making various other styling fixes for Button components. * Adding change file. * Addressing PR feedback. Co-authored-by: KHMakoto <[email protected]> * chore: Clean up Field tests and story imports in preparation of moving to individual packages (microsoft#25594) * Remove custom `isConformant` function for Field tests, and instead inline the customizations in each call to `isConformant` * Disable the `exported-top-level` test because the components will be exported as e.g. `InputField_unstable` from the component packages. * Change the stories to import from `@fluentui/react-components/unstable`, instead of the individual package. * Rename the `FieldComponent` type to `FieldControl` to correspond to the `control` slot name. * Tabs icon toggle (microsoft#25597) * Added regular filled icon toggling * yarn change * chore: Refactor Field components into the base component's package (microsoft#25593) Move Field components into their respective packages, as discussed in RFC microsoft#25380 * Update Component Implementation Epic template (microsoft#25480) * update to use vrscreenshotdiff beta * change lock file * update package version * applying package updates * update pr pipeline to add v8 * PR to add tasks in pipeline for v9 VRT integration (microsoft#25606) * fix: create valid export maps (microsoft#25558) * generate changefiles * chore(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (microsoft#25604) Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(react-dialog): removes unnecessary union case for DialogOpenChangeData (microsoft#25504) * templatize * update * templatize * updatE * refactor(scripts): remove deprecated exec abstractions (microsoft#25569) * fix(scripts): make eslint run again on pre-commit (microsoft#25537) * feat(react-components): Move AvatarGroup to stable (microsoft#25005) * update * update version * run partial tests * update * update * update * update * update * update * updatE * updatE * update version * update lock file * update name * update version * add quotes * docs: refactor Text documentation and add missing guidance for presets/alignment (microsoft#25587) Fixes microsoft#24341 Fixes microsoft#25548 * update * package version * fix(react-menu): remove unwanted aria attributes on context menu (microsoft#25615) * fix(react-menu): remove unwanted aria attributes on context menu * chore: updates trigger selector for cypress tests * remove unwanted param * update * applying package updates * convert * checkpoint * add regex * change convert script * updates * update sw version Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sean Monahan <[email protected]> Co-authored-by: Geoff Cox (Microsoft) <[email protected]> Co-authored-by: tomi-msft <[email protected]> Co-authored-by: Martin Hochel <[email protected]> Co-authored-by: Bernardo Sunderhus <[email protected]> Co-authored-by: chajun <[email protected]> Co-authored-by: Tristan Watanabe <[email protected]> Co-authored-by: Oleksandr Fediashov <[email protected]> Co-authored-by: David Zearing <[email protected]> Co-authored-by: Sarah Higley <[email protected]> Co-authored-by: Esteban Munoz Facusse <[email protected]> Co-authored-by: Fluent UI Build <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tudor Popa <[email protected]> Co-authored-by: Ben Howell <[email protected]> Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: KHMakoto <[email protected]> Co-authored-by: Marcos Moura <[email protected]>

… duplicate exports. (microsoft#25545) * expanding index. * change. * Replacing with inline deprecation exclusions. * setting export * to warning. * change. * moving rules around.

dzearing added 2 commits November 4, 2022 17:23

expanding index.

ea7b5ed

change.

15bd923

dzearing requested review from a team as code owners November 5, 2022 01:18

msft-fluent-ui-bot assigned smhigley Nov 5, 2022

Hotell added the Fluent UI react (v8) Issues about @fluentui/react (v8) label Nov 7, 2022

Hotell requested changes Nov 7, 2022

View reviewed changes

packages/react/src/index.ts Outdated Show resolved Hide resolved

msft-fluent-ui-bot added the Needs: Author Feedback label Nov 7, 2022

Replacing with inline deprecation exclusions.

1ddc428

msft-fluent-ui-bot removed the Needs: Author Feedback label Nov 7, 2022

setting export * to warning.

5aa9893

dzearing requested a review from a team as a code owner November 7, 2022 17:46

change.

1d1fc6c

Hotell reviewed Nov 8, 2022

View reviewed changes

Hotell approved these changes Nov 8, 2022

View reviewed changes

moving rules around.

4474f53

dzearing enabled auto-merge (squash) November 8, 2022 17:41

GeoffCoxMSFT approved these changes Nov 8, 2022

View reviewed changes

dzearing merged commit 6ab9ad7 into master Nov 8, 2022

khmakoto deleted the expand-index branch April 6, 2023 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

dzearing commented Nov 5, 2022

size-auditor bot commented Nov 5, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 5, 2022 •

edited

Loading

fabricteam commented Nov 5, 2022 •

edited

Loading

fabricteam commented Nov 5, 2022 •

edited

Loading

spmonahan commented Nov 7, 2022

JasonGore commented Nov 7, 2022

Hotell commented Nov 7, 2022

Hotell left a comment

dzearing commented Nov 7, 2022

fabricteam commented Nov 7, 2022 •

edited

Loading

fabricteam commented Nov 7, 2022 •

edited

Loading

GeoffCoxMSFT commented Nov 7, 2022

dzearing commented Nov 7, 2022

Hotell Nov 8, 2022

Hotell left a comment

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. #25545

Conversation

dzearing commented Nov 5, 2022

Repro

Current Behavior

New Behavior

Notes

Related Issue(s)

size-auditor bot commented Nov 5, 2022 • edited Loading

Asset size changes

codesandbox-ci bot commented Nov 5, 2022 • edited Loading

fabricteam commented Nov 5, 2022 • edited Loading

📊 Bundle size report

fabricteam commented Nov 5, 2022 • edited Loading

Perf Analysis (@fluentui/react)

spmonahan commented Nov 7, 2022

JasonGore commented Nov 7, 2022

Hotell commented Nov 7, 2022

Hotell left a comment

Choose a reason for hiding this comment

dzearing commented Nov 7, 2022

fabricteam commented Nov 7, 2022 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented Nov 7, 2022 • edited Loading

Perf Analysis (@fluentui/react-northstar)

GeoffCoxMSFT commented Nov 7, 2022

dzearing commented Nov 7, 2022

Hotell Nov 8, 2022

Choose a reason for hiding this comment

Hotell left a comment

Choose a reason for hiding this comment

size-auditor bot commented Nov 5, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 5, 2022 •

edited

Loading

fabricteam commented Nov 5, 2022 •

edited

Loading

fabricteam commented Nov 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Nov 7, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 7, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)