feat: Implement focusMode prop for DataGrid, apply role="grid" correctly
#25530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5de3909d8110cf1e9f17995108629060c306cb4c (build) |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ec52d3:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1265 | 1293 | 5000 | |
| Button | mount | 916 | 931 | 5000 | |
| FluentProvider | mount | 1480 | 1479 | 5000 | |
| FluentProviderWithTheme | mount | 573 | 581 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 536 | 543 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 576 | 571 | 10 | |
| MakeStyles | mount | 1943 | 1948 | 50000 | |
| SpinButton | mount | 2381 | 2339 | 5000 |
ling1726
changed the title
focusMode prop for DataGrid, apply role="grid" correctly
layershifter
approved these changes
Nov 7, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…ectly (microsoft#25530) * feat: DataGrid cells navigable by default, apply role="grid" correctly * update snapshots * changefile * imlement focusMode prop * update changefile * update snapshot
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…ectly (microsoft#25530) * feat: DataGrid cells navigable by default, apply role="grid" correctly * update snapshots * changefile * imlement focusMode prop * update changefile * update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies
useArrowNagivationGroupby default toDataGridwhen thefocusModeprop is set. Also sets correct roles for `gridFixes #25478
Fixes #25477