Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ToolbarRadio example and click event #25509

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

chpalac
Copy link
Contributor

@chpalac chpalac commented Nov 3, 2022

Overview

Fix ToolbarRadio storie and click that was being prevented

@size-auditor
Copy link

size-auditor bot commented Nov 3, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5de3909d8110cf1e9f17995108629060c306cb4c (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 3, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.941 kB
17.678 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.907 kB
52.983 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 5de3909d8110cf1e9f17995108629060c306cb4c

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 3, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1294 1275 5000
Button mount 924 932 5000
FluentProvider mount 1512 1491 5000
FluentProviderWithTheme mount 583 582 10
FluentProviderWithTheme virtual-rerender 543 546 10
FluentProviderWithTheme virtual-rerender-with-unmount 570 572 10
MakeStyles mount 1979 1976 50000
SpinButton mount 2383 2360 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5714272:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@chpalac chpalac requested a review from ling1726 November 7, 2022 08:42
@chpalac chpalac merged commit 169e9b9 into microsoft:master Nov 7, 2022
@chpalac chpalac deleted the fix/toolbar-radio-example branch November 7, 2022 13:26
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* fix: ToolbarRadio example and click

* chore: add changes

* chore: add tests
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* fix: ToolbarRadio example and click

* chore: add changes

* chore: add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants