Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-storybook, react-storybook-addon): migrate to new package structure #25482

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Nov 2, 2022
@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 2, 2022
@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 2, 2022 04:01
@TristanWatanabe TristanWatanabe requested review from a team as code owners November 2, 2022 04:01
@size-auditor
Copy link

size-auditor bot commented Nov 2, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cd78876740a3e4093470068bf3c8611ceca733c5 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 2, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.906 kB
52.963 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against cd78876740a3e4093470068bf3c8611ceca733c5

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 504343a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 2, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1277 1278 5000
Button mount 922 941 5000
FluentProvider mount 1486 1497 5000
FluentProviderWithTheme mount 578 579 10
FluentProviderWithTheme virtual-rerender 543 544 10
FluentProviderWithTheme virtual-rerender-with-unmount 584 575 10
MakeStyles mount 1955 1981 50000
SpinButton mount 2317 2321 5000

@TristanWatanabe TristanWatanabe merged commit 547d018 into microsoft:master Nov 4, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-react-storybook branch November 4, 2022 15:40
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants