Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tools): add unstable API setup updates #25355

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 24, 2022

Current Behavior

  • setting export maps for both stable and unstable is mixed within 1 function call which breaks domain boundaries and hard migration by scope
  • export maps are not set by source of truth which is presence of main and module fields

New Behavior

  • new API setupUnstableApi that handles package.json and api-extractor updates for unstable API (encapsulates logic so it's easy to turn off for scoped migration runs)
  • export maps are created based on main and module fields

Related Issue(s)

Follows #25033

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against a560d5fd83652a667bbdfd5cab6082c8ab01a6c2

@size-auditor
Copy link

size-auditor bot commented Oct 24, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a560d5fd83652a667bbdfd5cab6082c8ab01a6c2 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7709379:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@Hotell Hotell marked this pull request as ready for review October 24, 2022 17:44
@Hotell Hotell requested a review from a team as a code owner October 24, 2022 17:44
@Hotell Hotell merged commit 6eb171e into microsoft:master Oct 25, 2022
@Hotell Hotell deleted the hotell/build/api-stripping-migration-unstable-api-gen branch October 25, 2022 12:24
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 25, 2022
* master: (106 commits)
  fix: PopoverTriggerChildProps should be exported (microsoft#25159)
  feat: replace ToolbarRadio implementation by usage of toggle button as Radio (microsoft#25343)
  docs: improve Toolbar docs examples (microsoft#25269)
  feat(tools): add unstable API setup updates (microsoft#25355)
  applying package updates
  Fix wrong narration when legend selected (microsoft#24903)
  applying package updates
  chore(react-persona): Update beachball settings and change file's type (microsoft#25363)
  chore: Refactor Field VR tests to have individual tests per component (microsoft#25263)
  chore(react-persona, react-components, vr-tests-v9): Reverting react-persona's version to beta   (microsoft#25357)
  Publishing migration package (microsoft#25354)
  fix: Detailslist is still tabbable when isHeaderVisible=false (microsoft#25342)
  fix: list even/odd off-by-one issue (microsoft#25358)
  feat: add Dropdown a11y spec (microsoft#24917)
  spinbutton: update internal padding for small size (microsoft#25286)
  chore(global-context): migrate to new package structure (microsoft#25341)
  feat: Add validationState to Progress, to make the bar red or green (microsoft#25253)
  feat: Add accessibility scenarios for Fluent UI v9 components #3 (microsoft#23334)
  feat(Dropdown): Freeform search should be case insensitive (microsoft#24879)
  feat(what-input): Limit keyboard detection in inputs (microsoft#25087)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants