Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(react-infobutton): Adding component's spec #25251
docs(react-infobutton): Adding component's spec #25251
Changes from 4 commits
bd7056e
b32758a
26ebd5a
1120637
22c1595
a36ef96
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image shows the popover in the "above-start" position. Will
InfoButton
support positioning of the popover?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that will be done through the root as it takes the popover props as well. The updated types now have the Popover props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello :)
there was no similar component in
v0
or in 'v8' but one version exists in the TMP repository(in MS Teams code)Implementation accessibility details are following:
https://domoreexp.visualstudio.com/Teamspace/_git/teams-modular-packages/pullrequest/477885
This approach was approved by accessibility PM for MS Teams(Brett Humphrey).
If there is a button used, then generally screen reader users would expect there is some action available on the button.
I believe we should be aligned together with v9 and MS Teams component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we then also need to use
aria-describedby
oraria-labeledby
on the button itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't set yet, once we iron it out, I'll update the spec.