-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-aria): migrate to new package structure #25199
chore(react-aria): migrate to new package structure #25199
Conversation
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f6f3e4b27f850577890dce15000bf8d4dedc4381 (build) |
This is currently throwing an error in |
@@ -1,6 +1,6 @@ | |||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I was planing to simply remove storybook from this package at the moment, since this is an internal package (internal in the meaning of not being re-exported by react-components), and this documentation is not being very helpful at the moment
As far as I understood changes made on the new API extraction (correct me if I'm wrong @Hotell), if the method is marked as The way to ensure this will keep being an internally used dependency is by simply not re-exporting it from |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 58710fa:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1266 | 1238 | 5000 | |
Button | mount | 939 | 866 | 5000 | |
FluentProvider | mount | 1535 | 1447 | 5000 | |
FluentProviderWithTheme | mount | 556 | 635 | 10 | |
FluentProviderWithTheme | virtual-rerender | 523 | 582 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 625 | 10 | |
MakeStyles | mount | 1903 | 1787 | 50000 | |
SpinButton | mount | 2550 | 2453 | 5000 |
@bsunderhus Pulling out API stripping #23369 and export map changes #25033 from this PR to reduce scope. Those changes will now be applied by #25319 |
* Update Link.stories.tsx * Update Link.stories.tsx * update * chore(babel-preset-global-context): migrate to new package structure (microsoft#25340) * chore(react-aria): migrate to new package structure (microsoft#25199) * feat: re-export react-table logic hooks (microsoft#25386) * applying package updates * Website: fix focus border on UHF footer links (microsoft#25389) * use not uhf link to increase specificity instead of body tag * improve comment * fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388) * chore(react-divider): migrate to new package structure (microsoft#25360) * chore(react-select): migrate to new package structure (microsoft#25359) * feat: Add support for the wbtx whiteboard file extension (microsoft#25346) * revert some changes * update storywright version * rename * rename * updatE * update * update * update * update * not needed * update * update Co-authored-by: Tristan Watanabe <[email protected]> Co-authored-by: Bernardo Sunderhus <[email protected]> Co-authored-by: Fluent UI Build <[email protected]> Co-authored-by: Micah Godbolt <[email protected]> Co-authored-by: jieleiwang <[email protected]>
* master: (21 commits) fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416) chore: adds disableButtonEnhancement on triggers (microsoft#25211) applying package updates feat: Add support for the wbtx whiteboard file extension (microsoft#25346) chore(react-select): migrate to new package structure (microsoft#25359) chore(react-divider): migrate to new package structure (microsoft#25360) fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388) Website: fix focus border on UHF footer links (microsoft#25389) applying package updates feat: re-export react-table logic hooks (microsoft#25386) chore(react-aria): migrate to new package structure (microsoft#25199) chore(babel-preset-global-context): migrate to new package structure (microsoft#25340) applying package updates fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381) applying package updates fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374) allow details element to be toggled inside selection and focus zones (microsoft#25324) fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367) update fast element and foundation package versions stable (microsoft#25364) chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362) ...
Changes:
migrate-converged-pkg
which reflects updates made in chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks #24458.stories/
folder in the root of the package.common/
folder and moves contents to newtesting/
folderdocs/
folder to package root.Issue: