-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update FAST packages to resolve issues with form constraint validation on form associated elements #24557
update FAST packages to resolve issues with form constraint validation on form associated elements #24557
Conversation
…n on form associated elements
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ce1e15:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a3081ce8cb9aef65dd64fe9328b84959d7b0e665 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1323 | 1300 | 5000 | |
Button | mount | 963 | 958 | 5000 | |
FluentProvider | mount | 1586 | 1593 | 5000 | |
FluentProviderWithTheme | mount | 627 | 636 | 10 | |
FluentProviderWithTheme | virtual-rerender | 596 | 595 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 633 | 631 | 10 | |
MakeStyles | mount | 1894 | 1888 | 50000 | |
SpinButton | mount | 2555 | 2515 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this will also help out the FAST Blazor project.
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
RadioGroupMinimalPerf.default | 446 | 401 | 1.11:1 |
AvatarMinimalPerf.default | 196 | 178 | 1.1:1 |
ButtonMinimalPerf.default | 161 | 149 | 1.08:1 |
TableMinimalPerf.default | 407 | 382 | 1.07:1 |
DividerMinimalPerf.default | 352 | 332 | 1.06:1 |
AttachmentMinimalPerf.default | 142 | 135 | 1.05:1 |
CarouselMinimalPerf.default | 480 | 459 | 1.05:1 |
ListMinimalPerf.default | 526 | 499 | 1.05:1 |
RefMinimalPerf.default | 218 | 207 | 1.05:1 |
ChatMinimalPerf.default | 719 | 694 | 1.04:1 |
ImageMinimalPerf.default | 365 | 351 | 1.04:1 |
ListCommonPerf.default | 609 | 585 | 1.04:1 |
AlertMinimalPerf.default | 277 | 270 | 1.03:1 |
FormMinimalPerf.default | 379 | 367 | 1.03:1 |
MenuMinimalPerf.default | 849 | 828 | 1.03:1 |
ProviderMergeThemesPerf.default | 1281 | 1240 | 1.03:1 |
AttachmentSlotsPerf.default | 1088 | 1069 | 1.02:1 |
ButtonOverridesMissPerf.default | 1469 | 1447 | 1.02:1 |
ChatDuplicateMessagesPerf.default | 283 | 277 | 1.02:1 |
HeaderMinimalPerf.default | 347 | 341 | 1.02:1 |
HeaderSlotsPerf.default | 763 | 746 | 1.02:1 |
LayoutMinimalPerf.default | 350 | 343 | 1.02:1 |
ListNestedPerf.default | 549 | 539 | 1.02:1 |
PortalMinimalPerf.default | 174 | 170 | 1.02:1 |
SplitButtonMinimalPerf.default | 4377 | 4303 | 1.02:1 |
TooltipMinimalPerf.default | 2359 | 2316 | 1.02:1 |
CardMinimalPerf.default | 533 | 528 | 1.01:1 |
CheckboxMinimalPerf.default | 2661 | 2647 | 1.01:1 |
DropdownMinimalPerf.default | 3181 | 3157 | 1.01:1 |
FlexMinimalPerf.default | 277 | 275 | 1.01:1 |
ListWith60ListItems.default | 596 | 588 | 1.01:1 |
RosterPerf.default | 2147 | 2134 | 1.01:1 |
SkeletonMinimalPerf.default | 326 | 323 | 1.01:1 |
SliderMinimalPerf.default | 1683 | 1670 | 1.01:1 |
IconMinimalPerf.default | 639 | 634 | 1.01:1 |
TreeMinimalPerf.default | 788 | 777 | 1.01:1 |
TreeWith60ListItems.default | 165 | 163 | 1.01:1 |
ButtonSlotsPerf.default | 544 | 544 | 1:1 |
DatepickerMinimalPerf.default | 5590 | 5590 | 1:1 |
EmbedMinimalPerf.default | 4124 | 4133 | 1:1 |
InputMinimalPerf.default | 1293 | 1298 | 1:1 |
ItemLayoutMinimalPerf.default | 1173 | 1168 | 1:1 |
LoaderMinimalPerf.default | 676 | 674 | 1:1 |
ReactionMinimalPerf.default | 368 | 369 | 1:1 |
TextAreaMinimalPerf.default | 447 | 446 | 1:1 |
AccordionMinimalPerf.default | 148 | 150 | 0.99:1 |
AnimationMinimalPerf.default | 516 | 519 | 0.99:1 |
BoxMinimalPerf.default | 329 | 331 | 0.99:1 |
DialogMinimalPerf.default | 770 | 778 | 0.99:1 |
LabelMinimalPerf.default | 369 | 373 | 0.99:1 |
MenuButtonMinimalPerf.default | 1691 | 1701 | 0.99:1 |
ProviderMinimalPerf.default | 390 | 395 | 0.99:1 |
SegmentMinimalPerf.default | 331 | 334 | 0.99:1 |
StatusMinimalPerf.default | 675 | 683 | 0.99:1 |
CustomToolbarPrototype.default | 2886 | 2919 | 0.99:1 |
ToolbarMinimalPerf.default | 907 | 917 | 0.99:1 |
DropdownManyItemsPerf.default | 651 | 667 | 0.98:1 |
GridMinimalPerf.default | 322 | 328 | 0.98:1 |
PopupMinimalPerf.default | 610 | 629 | 0.97:1 |
TableManyItemsPerf.default | 1830 | 1887 | 0.97:1 |
TextMinimalPerf.default | 320 | 344 | 0.93:1 |
VideoMinimalPerf.default | 673 | 734 | 0.92:1 |
ChatWithPopoverPerf.default | 363 | 397 | 0.91:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
buttonNative | mount | 109 | 121 | 5000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 775 | 758 | 5000 | |
Breadcrumb | mount | 2514 | 2482 | 1000 | |
Checkbox | mount | 2249 | 2221 | 5000 | |
CheckboxBase | mount | 1964 | 1930 | 5000 | |
ChoiceGroup | mount | 3946 | 3954 | 5000 | |
ComboBox | mount | 826 | 825 | 1000 | |
CommandBar | mount | 9215 | 9162 | 1000 | |
ContextualMenu | mount | 10762 | 10836 | 1000 | |
DefaultButton | mount | 957 | 956 | 5000 | |
DetailsRow | mount | 3279 | 3308 | 5000 | |
DetailsRowFast | mount | 3304 | 3285 | 5000 | |
DetailsRowNoStyles | mount | 3124 | 3087 | 5000 | |
Dialog | mount | 2656 | 2690 | 1000 | |
DocumentCardTitle | mount | 138 | 141 | 1000 | |
Dropdown | mount | 2827 | 2851 | 5000 | |
FocusTrapZone | mount | 1551 | 1618 | 5000 | |
FocusZone | mount | 1530 | 1531 | 5000 | |
IconButton | mount | 1502 | 1498 | 5000 | |
Label | mount | 288 | 293 | 5000 | |
Layer | mount | 3886 | 3874 | 5000 | |
Link | mount | 400 | 401 | 5000 | |
MenuButton | mount | 1238 | 1262 | 5000 | |
MessageBar | mount | 1941 | 1938 | 5000 | |
Nav | mount | 2868 | 2822 | 1000 | |
OverflowSet | mount | 923 | 950 | 5000 | |
Panel | mount | 2147 | 2147 | 1000 | |
Persona | mount | 849 | 854 | 1000 | |
Pivot | mount | 1219 | 1227 | 1000 | |
PrimaryButton | mount | 1105 | 1117 | 5000 | |
Rating | mount | 6609 | 6637 | 5000 | |
SearchBox | mount | 1084 | 1084 | 5000 | |
Shimmer | mount | 2471 | 2486 | 5000 | |
Slider | mount | 1650 | 1662 | 5000 | |
SpinButton | mount | 4253 | 4286 | 5000 | |
Spinner | mount | 375 | 370 | 5000 | |
SplitButton | mount | 2878 | 2666 | 5000 | |
Stack | mount | 428 | 427 | 5000 | |
StackWithIntrinsicChildren | mount | 1964 | 1934 | 5000 | |
StackWithTextChildren | mount | 4391 | 4382 | 5000 | |
SwatchColorPicker | mount | 10133 | 10042 | 5000 | |
TagPicker | mount | 2227 | 2262 | 5000 | |
TeachingBubble | mount | 90889 | 90090 | 5000 | |
Text | mount | 349 | 361 | 5000 | |
TextField | mount | 1189 | 1169 | 5000 | |
ThemeProvider | mount | 1114 | 1113 | 5000 | |
ThemeProvider | virtual-rerender | 661 | 653 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1744 | 1721 | 5000 | |
Toggle | mount | 685 | 701 | 5000 | |
buttonNative | mount | 109 | 121 | 5000 | Possible regression |
@micahgodbolt once you have a moment, the only changes here relate to our resolved packages in the yarn.lock file. Thanks! |
Description
Updates FAST packages to resolve issues with form constraint validation on form associated elements
Related Issue(s)
Fixes #