feat(useTable): selection manager to avoid calling multiple hooks #24377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a `createSelectionManager` function to manage selection state independently of react and avoids calling state hooks twice on each render
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 463d1b9:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 06dfea83bd8c002e8219b97ab0f3deecc1365e37 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1488 | 1493 | 5000 | |
| Button | mount | 1124 | 1130 | 5000 | |
| FluentProvider | mount | 1861 | 1852 | 5000 | |
| FluentProviderWithTheme | mount | 751 | 745 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 688 | 697 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 741 | 738 | 10 | |
| MakeStyles | mount | 2277 | 2249 | 50000 | |
| SpinButton | mount | 2923 | 2991 | 5000 |
packages/react-components/react-table/src/hooks/useSelection.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-table/src/hooks/selectionManager.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+13
to
+21
| const [selectionManager, setSelectionManager] = React.useState(() => | ||
| createSelectionManager(selectionMode, setSelected), | ||
| ); | ||
|
|
||
| return selectionMode === 'multiselect' ? multipleSelectionState : singleSelectionState; | ||
| React.useEffect(() => { | ||
| if (prevSelectionMode !== selectionMode) { | ||
| setSelectionManager(createSelectionManager(selectionMode, setSelected)); | ||
| } | ||
| }, [selectionMode, prevSelectionMode]); |
There was a problem hiding this comment.
not blocking: Let's pair on creating useSingletone or something like that as people who are not aware about Strict mode issues will be confused.
There was a problem hiding this comment.
yeah we even have a task for it, but not sure how much of a priority 18 is yet #24085
bsunderhus
reviewed
Aug 17, 2022
layershifter
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a
createSelectionManagerconstructor to manage selection stateindependently of react and avoids calling state hooks twice on each
render
Addresses #24226