Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docsite): add build time script to fix the website title from Web… #24324

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

tudorpopams
Copy link
Contributor

Current Behavior

The current website default title is "Webpack App":

image

There is currently no option in Storybook to add a custom title, as the last comment in this issue specifies.

New Behavior

The current fix involves running a script after the build-storybook command finishes running which changes the <title> tag value to the desired one.

@tudorpopams tudorpopams requested a review from a team as a code owner August 10, 2022 15:31
@tudorpopams tudorpopams self-assigned this Aug 10, 2022
@tudorpopams tudorpopams requested review from a team as code owners August 10, 2022 15:31
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 10, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a30d14a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2022

📊 Bundle size report

🤖 This report was generated against e6cf183695d6d67a24e038c49a876224e5ed35e5

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e6cf183695d6d67a24e038c49a876224e5ed35e5 (build)

@ling1726
Copy link
Member

if we modify the manager-head.html page like here does that mean all pages will have that title or are they still overriden when the user navigates ?

@tudorpopams
Copy link
Contributor Author

if we modify the manager-head.html page like here does that mean all pages will have that title or are they still overriden when the user navigates ?

That will work on client side, but for places where you post the url and have the metadata fetched (like Outlook) it won't unfortunately.

apps/public-docsite-v9/.storybook/fix-title.js Outdated Show resolved Hide resolved
@Hotell
Copy link
Contributor

Hotell commented Aug 11, 2022

if we modify the manager-head.html page like here does that mean all pages will have that title or are they still overriden when the user navigates ?

it's about initial load @ling1726 , until js kicks in the static title is displayed....

@tudorpopams tudorpopams force-pushed the fix/docsite-initial-title branch from f970d9f to a30d14a Compare August 11, 2022 09:01
@Hotell
Copy link
Contributor

Hotell commented Aug 11, 2022

ship.it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants