-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docsite): add build time script to fix the website title from Web… #24324
fix(docsite): add build time script to fix the website title from Web… #24324
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a30d14a:
|
📊 Bundle size report🤖 This report was generated against e6cf183695d6d67a24e038c49a876224e5ed35e5 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e6cf183695d6d67a24e038c49a876224e5ed35e5 (build) |
if we modify the |
That will work on client side, but for places where you post the url and have the metadata fetched (like Outlook) it won't unfortunately. |
…pack App to Fluent UI React v9
…he iframe title too.
f970d9f
to
a30d14a
Compare
ship.it ! |
Current Behavior
The current website default title is "Webpack App":
There is currently no option in Storybook to add a custom title, as the last comment in this issue specifies.
New Behavior
The current fix involves running a script after the
build-storybook
command finishes running which changes the<title>
tag value to the desired one.