Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Chart component - react-charting - Production Fixes #23886

Closed
wants to merge 61 commits into from

Conversation

Apurva-tech
Copy link
Member

Verified that:

  • Code is up-to-date with the master branch
  • Your changes are covered by tests (if possible)
  • You've run yarn change locally

Current Behavior

The deployed link has bugs related to SVG width

New Behavior

  • Bug fixes related to SVG Width
  • Optional field for SubText and Metric Name in the Node

Apurva-tech and others added 30 commits June 21, 2022 16:02
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51ae84c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 13, 2022

📊 Bundle size report

🤖 This report was generated against 748e703b9b977b17919af952742a3a1d290e0bce

@size-auditor
Copy link

size-auditor bot commented Jul 13, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 748e703b9b977b17919af952742a3a1d290e0bce (build)

import { hierarchy, tree } from 'd3-hierarchy';
import { classNamesFunction } from '@fluentui/react/lib/Utilities';
import { IProcessedStyleSet } from '@fluentui/react/lib/Styling';
import { FocusZone } from '@fluentui/react-focus';
// import { wrapTextInsideNode } from '../../utilities/utilities';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants