fix(Select): handle "defaultValue" #23463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5462e7d:
|
layershifter
force-pushed
the
fix/select-defaultvalue
branch
from
683b5e8 to
ed49f87
Compare
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1657 | 1646 | 5000 | |
| Button | mount | 1232 | 1276 | 5000 | |
| FluentProvider | mount | 2856 | 2842 | 5000 | |
| FluentProviderWithTheme | mount | 913 | 955 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 898 | 887 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 972 | 973 | 10 | |
| MakeStyles | mount | 2477 | 2493 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6840cfac3419b064c2e360b25291c38de905d937 (build) |
|
@microsoft/cxe-coastal can you please review? It blocks an another PR. Thanks. |
layershifter
force-pushed
the
fix/select-defaultvalue
branch
from
ed49f87 to
5462e7d
Compare
@microsoft/cxe-coastal friendly ping. |
smhigley
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR fixes two issues.
defaultValueinSelectcomponent (see [Bug]: Select does not handledefaultValue#23462 for more details)InitialValuestory to usedefaultValueon<Select />instead ofselectedon<option />(see [Bug]: Select features incorrect pattern in stories #23461). It's the official approach, https://reactjs.org/docs/forms.html#the-select-tag. This issue is blocking chore: add SSR tests (test command) #23457 as causes hydration errors with SSR.Related Issue(s)
Fixes #23461
Fixes #23462