chore: unscope cypress E2E in CI #23460

ling1726 · 2022-06-08T12:49:13Z

There is no real reason to scope cypress tests because the --since
argument in lage should already help with running only affected tests

There is no real reason to scope cypress tests since the `--since` argument in lage should already help with running only affected tests

codesandbox-ci · 2022-06-08T12:56:22Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34825be:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-06-08T13:01:22Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fbd2de31c257aa192dbc69d6eacda6388af06b30 (build)

fabricteam · 2022-06-08T13:02:06Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1177	1151	5000
Button	mount	657	660	5000
FluentProvider	mount	2374	2295	5000
FluentProviderWithTheme	mount	351	329	10
FluentProviderWithTheme	virtual-rerender	279	287	10
FluentProviderWithTheme	virtual-rerender-with-unmount	373	387	10
MakeStyles	mount	2025	1985	50000

fabricteam · 2022-06-08T13:05:53Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`74.947 kB` `22.722 kB`
`react-avatar` Avatar	`45.538 kB` `13.298 kB`
`react-badge` Badge	`20.929 kB` `6.554 kB`
`react-badge` CounterBadge	`21.833 kB` `6.861 kB`
`react-badge` PresenceBadge	`22.23 kB` `6.673 kB`
`react-button` Button	`33.796 kB` `9.151 kB`
`react-button` CompoundButton	`40.703 kB` `10.403 kB`
`react-button` MenuButton	`35.968 kB` `9.893 kB`
`react-button` SplitButton	`43.209 kB` `11.195 kB`
`react-button` ToggleButton	`48.279 kB` `10.573 kB`
`react-card` Card - All	`66.114 kB` `18.69 kB`
`react-card` Card	`61.27 kB` `17.569 kB`
`react-card` CardFooter	`7.737 kB` `3.264 kB`
`react-card` CardHeader	`9.302 kB` `3.779 kB`
`react-card` CardPreview	`7.838 kB` `3.316 kB`
`react-combobox` Combobox	`61.494 kB` `21.019 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`184.781 kB` `51.176 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.988 kB` `11.108 kB`
`react-divider` Divider	`15.485 kB` `5.534 kB`
`react-image` Image	`9.956 kB` `3.922 kB`
`react-input` Input	`22.009 kB` `7.194 kB`
`react-label` Label	`8.514 kB` `3.526 kB`
`react-link` Link	`11.358 kB` `4.58 kB`
`react-menu` Menu (including children components)	`113.605 kB` `34.444 kB`
`react-menu` Menu (including selectable components)	`116.78 kB` `34.908 kB`
`react-overflow` hooks only	`10.839 kB` `4.146 kB`
`react-popover` Popover	`103.84 kB` `31.603 kB`
`react-portal` Portal	`9.267 kB` `3.417 kB`
`react-positioning` usePositioning	`23.846 kB` `8.29 kB`
`react-provider` FluentProvider	`14.037 kB` `5.307 kB`
`react-radio` Radio	`29.397 kB` `10.049 kB`
`react-radio` RadioGroup	`13.595 kB` `5.42 kB`
`react-select` Select	`18.673 kB` `6.702 kB`
`react-slider` Slider	`25.173 kB` `8.12 kB`
`react-spinbutton` SpinButton	`41.967 kB` `11.816 kB`
`react-spinner` Spinner	`18.159 kB` `5.99 kB`
`react-switch` Switch	`25.37 kB` `8.208 kB`
`react-text` Text - Default	`10.848 kB` `4.239 kB`
`react-text` Text - Wrappers	`14.158 kB` `4.659 kB`
`react-textarea` Textarea	`21.057 kB` `7.079 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.363 kB` `7.043 kB`
`react-theme` Teams: Light theme	`19.806 kB` `5.699 kB`
`react-tooltip` Tooltip	`43.766 kB` `15.075 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against fbd2de31c257aa192dbc69d6eacda6388af06b30}

ling1726 · 2022-06-08T13:06:53Z

/azp run

azure-pipelines · 2022-06-08T13:07:13Z

Azure Pipelines successfully started running 3 pipeline(s).

fabricteam · 2022-06-08T13:17:36Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AccordionMinimalPerf.default	133	125	1.06:1	analysis
AlertMinimalPerf.default	218	221	0.99:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	128	119	1.08:1
ButtonMinimalPerf.default	139	130	1.07:1
RadioGroupMinimalPerf.default	382	361	1.06:1
HeaderMinimalPerf.default	303	289	1.05:1
CarouselMinimalPerf.default	402	388	1.04:1
ChatMinimalPerf.default	634	610	1.04:1
AvatarMinimalPerf.default	162	157	1.03:1
LabelMinimalPerf.default	321	312	1.03:1
ProviderMinimalPerf.default	336	326	1.03:1
TableMinimalPerf.default	342	331	1.03:1
TextAreaMinimalPerf.default	412	399	1.03:1
AnimationMinimalPerf.default	458	449	1.02:1
BoxMinimalPerf.default	277	271	1.02:1
DropdownManyItemsPerf.default	575	562	1.02:1
RosterPerf.default	940	922	1.02:1
IconMinimalPerf.default	509	497	1.02:1
TableManyItemsPerf.default	1629	1590	1.02:1
ChatWithPopoverPerf.default	319	315	1.01:1
EmbedMinimalPerf.default	3460	3425	1.01:1
ItemLayoutMinimalPerf.default	1000	987	1.01:1
ListCommonPerf.default	526	523	1.01:1
MenuButtonMinimalPerf.default	1445	1430	1.01:1
PopupMinimalPerf.default	524	517	1.01:1
SkeletonMinimalPerf.default	276	273	1.01:1
SliderMinimalPerf.default	1439	1418	1.01:1
TextMinimalPerf.default	287	283	1.01:1
TreeMinimalPerf.default	675	668	1.01:1
VideoMinimalPerf.default	531	528	1.01:1
ButtonSlotsPerf.default	464	463	1:1
DatepickerMinimalPerf.default	4781	4805	1:1
DropdownMinimalPerf.default	2632	2645	1:1
InputMinimalPerf.default	1096	1096	1:1
LayoutMinimalPerf.default	294	293	1:1
ListNestedPerf.default	452	453	1:1
LoaderMinimalPerf.default	568	570	1:1
MenuMinimalPerf.default	718	716	1:1
ReactionMinimalPerf.default	308	307	1:1
SplitButtonMinimalPerf.default	3674	3669	1:1
CustomToolbarPrototype.default	2289	2297	1:1
TooltipMinimalPerf.default	946	945	1:1
ButtonOverridesMissPerf.default	1256	1267	0.99:1
CheckboxMinimalPerf.default	2261	2278	0.99:1
DialogMinimalPerf.default	639	643	0.99:1
DividerMinimalPerf.default	296	298	0.99:1
FormMinimalPerf.default	329	332	0.99:1
HeaderSlotsPerf.default	622	626	0.99:1
ImageMinimalPerf.default	323	325	0.99:1
ProviderMergeThemesPerf.default	1052	1058	0.99:1
SegmentMinimalPerf.default	282	285	0.99:1
StatusMinimalPerf.default	551	558	0.99:1
AttachmentSlotsPerf.default	901	919	0.98:1
CardMinimalPerf.default	469	478	0.98:1
ChatDuplicateMessagesPerf.default	228	232	0.98:1
ListWith60ListItems.default	503	513	0.98:1
RefMinimalPerf.default	189	192	0.98:1
ToolbarMinimalPerf.default	790	804	0.98:1
GridMinimalPerf.default	272	279	0.97:1
ListMinimalPerf.default	420	431	0.97:1
PortalMinimalPerf.default	137	141	0.97:1
TreeWith60ListItems.default	125	130	0.96:1
FlexMinimalPerf.default	228	240	0.95:1

fabricteam · 2022-06-08T13:22:15Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1061	1078	5000
Breadcrumb	mount	3000	3004	1000
Checkbox	mount	1716	1766	5000
CheckboxBase	mount	1491	1557	5000
ChoiceGroup	mount	5386	5390	5000
ComboBox	mount	1104	1111	1000
CommandBar	mount	11338	11468	1000
ContextualMenu	mount	12639	12663	1000
DefaultButton	mount	1303	1308	5000
DetailsRow	mount	4295	4310	5000
DetailsRowFast	mount	4303	4294	5000
DetailsRowNoStyles	mount	4140	4086	5000
Dialog	mount	2527	2483	1000
DocumentCardTitle	mount	213	208	1000
Dropdown	mount	4073	3794	5000
FocusTrapZone	mount	2010	2002	5000
FocusZone	mount	1978	2030	5000
IconButton	mount	2056	2044	5000
Label	mount	398	395	5000
Layer	mount	3370	3275	5000
Link	mount	535	555	5000
MenuButton	mount	1745	1723	5000
MessageBar	mount	2318	2363	5000
Nav	mount	3753	3710	1000
OverflowSet	mount	1217	1221	5000
Panel	mount	2422	2389	1000
Persona	mount	1154	1188	1000
Pivot	mount	1647	1636	1000
PrimaryButton	mount	1519	1519	5000
Rating	mount	8925	8990	5000
SearchBox	mount	1579	1572	5000
Shimmer	mount	2898	2951	5000
Slider	mount	2192	2180	5000
SpinButton	mount	5677	5629	5000
Spinner	mount	471	478	5000
SplitButton	mount	3603	3628	5000
Stack	mount	616	602	5000
StackWithIntrinsicChildren	mount	2816	2733	5000
StackWithTextChildren	mount	6265	6267	5000
SwatchColorPicker	mount	13056	12986	5000
TagPicker	mount	3125	3186	5000
TeachingBubble	mount	105460	106520	5000
Text	mount	507	512	5000
TextField	mount	1670	1650	5000
ThemeProvider	mount	1308	1324	5000
ThemeProvider	virtual-rerender	693	684	5000
ThemeProvider	virtual-rerender-with-unmount	2126	2194	5000
Toggle	mount	900	909	5000
buttonNative	mount	143	151	5000

There is no real reason to scope cypress tests since the `--since` argument in lage should already help with running only affected tests

chore: unscope cypress E2E in CI

34825be

There is no real reason to scope cypress tests since the `--since` argument in lage should already help with running only affected tests

ling1726 marked this pull request as ready for review June 8, 2022 12:49

ling1726 requested a review from a team as a code owner June 8, 2022 12:49

msft-fluent-ui-bot assigned ling1726 Jun 8, 2022

github-actions bot added this to the June Project Cycle Q2 2022 milestone Jun 8, 2022

ling1726 mentioned this pull request Jun 8, 2022

chore: Add tests for babel-preset-global-context #23453

Merged

ling1726 closed this Jun 8, 2022

ling1726 reopened this Jun 8, 2022

tudorpopams requested a review from Hotell June 9, 2022 12:24

Hotell approved these changes Jun 9, 2022

View reviewed changes

spmonahan approved these changes Jun 9, 2022

View reviewed changes

ling1726 merged commit 13fe070 into microsoft:master Jun 9, 2022

marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022

chore: unscope cypress E2E in CI (microsoft#23460)

a823832

There is no real reason to scope cypress tests since the `--since` argument in lage should already help with running only affected tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: unscope cypress E2E in CI #23460

chore: unscope cypress E2E in CI #23460

ling1726 commented Jun 8, 2022

codesandbox-ci bot commented Jun 8, 2022

size-auditor bot commented Jun 8, 2022 •

edited

Loading

fabricteam commented Jun 8, 2022 •

edited

Loading

fabricteam commented Jun 8, 2022 •

edited

Loading

ling1726 commented Jun 8, 2022

azure-pipelines bot commented Jun 8, 2022

fabricteam commented Jun 8, 2022 •

edited

Loading

fabricteam commented Jun 8, 2022 •

edited

Loading

chore: unscope cypress E2E in CI #23460

chore: unscope cypress E2E in CI #23460

Conversation

ling1726 commented Jun 8, 2022

codesandbox-ci bot commented Jun 8, 2022

size-auditor bot commented Jun 8, 2022 • edited Loading

Asset size changes

fabricteam commented Jun 8, 2022 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented Jun 8, 2022 • edited Loading

📊 Bundle size report

ling1726 commented Jun 8, 2022

azure-pipelines bot commented Jun 8, 2022

fabricteam commented Jun 8, 2022 • edited Loading

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

fabricteam commented Jun 8, 2022 • edited Loading

Perf Analysis (@fluentui/react)

size-auditor bot commented Jun 8, 2022 •

edited

Loading

fabricteam commented Jun 8, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jun 8, 2022 •

edited

Loading

fabricteam commented Jun 8, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jun 8, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)