chore: Bump cypress to v10 #23435
Merged
chore: Bump cypress to v10 #23435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps cypress to [latest major v10](https://docs.cypress.io/guides/references/changelog#10-0-0) which introduces code config (`cypress.config.ts`). Done for both v9 and northstar.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33688ed:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 34ea0e466150ceca873360ddb21e9fcb89c9dd56 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 897 | 848 | 5000 | |
| Button | mount | 558 | 571 | 5000 | |
| FluentProvider | mount | 1866 | 1793 | 5000 | |
| FluentProviderWithTheme | mount | 266 | 274 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 236 | 229 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 332 | 295 | 10 | |
| MakeStyles | mount | 1532 | 1577 | 50000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 351 | 280 | 1.25:1 |
| TreeWith60ListItems.default | 141 | 113 | 1.25:1 |
| BoxMinimalPerf.default | 308 | 250 | 1.23:1 |
| SegmentMinimalPerf.default | 303 | 258 | 1.17:1 |
| ChatMinimalPerf.default | 624 | 543 | 1.15:1 |
| HeaderMinimalPerf.default | 299 | 259 | 1.15:1 |
| GridMinimalPerf.default | 277 | 247 | 1.12:1 |
| IconMinimalPerf.default | 532 | 474 | 1.12:1 |
| ChatDuplicateMessagesPerf.default | 258 | 233 | 1.11:1 |
| PortalMinimalPerf.default | 160 | 145 | 1.1:1 |
| TextMinimalPerf.default | 308 | 279 | 1.1:1 |
| ButtonOverridesMissPerf.default | 1276 | 1177 | 1.08:1 |
| ChatWithPopoverPerf.default | 312 | 289 | 1.08:1 |
| DividerMinimalPerf.default | 270 | 250 | 1.08:1 |
| LayoutMinimalPerf.default | 295 | 272 | 1.08:1 |
| TextAreaMinimalPerf.default | 397 | 366 | 1.08:1 |
| AttachmentMinimalPerf.default | 125 | 117 | 1.07:1 |
| ButtonMinimalPerf.default | 146 | 138 | 1.06:1 |
| FormMinimalPerf.default | 341 | 322 | 1.06:1 |
| PopupMinimalPerf.default | 535 | 505 | 1.06:1 |
| AttachmentSlotsPerf.default | 934 | 886 | 1.05:1 |
| DatepickerMinimalPerf.default | 4961 | 4715 | 1.05:1 |
| HeaderSlotsPerf.default | 650 | 621 | 1.05:1 |
| ListMinimalPerf.default | 424 | 405 | 1.05:1 |
| MenuMinimalPerf.default | 730 | 696 | 1.05:1 |
| TreeMinimalPerf.default | 690 | 664 | 1.04:1 |
| DropdownMinimalPerf.default | 2677 | 2610 | 1.03:1 |
| FlexMinimalPerf.default | 241 | 233 | 1.03:1 |
| ProviderMinimalPerf.default | 324 | 314 | 1.03:1 |
| RefMinimalPerf.default | 196 | 191 | 1.03:1 |
| SkeletonMinimalPerf.default | 251 | 246 | 1.02:1 |
| TableManyItemsPerf.default | 1579 | 1553 | 1.02:1 |
| TableMinimalPerf.default | 327 | 320 | 1.02:1 |
| ToolbarMinimalPerf.default | 801 | 785 | 1.02:1 |
| AnimationMinimalPerf.default | 460 | 455 | 1.01:1 |
| AvatarMinimalPerf.default | 151 | 150 | 1.01:1 |
| ButtonSlotsPerf.default | 442 | 438 | 1.01:1 |
| DialogMinimalPerf.default | 640 | 636 | 1.01:1 |
| ReactionMinimalPerf.default | 268 | 266 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1382 | 1384 | 1:1 |
| StatusMinimalPerf.default | 537 | 537 | 1:1 |
| CustomToolbarPrototype.default | 2293 | 2289 | 1:1 |
| RadioGroupMinimalPerf.default | 330 | 334 | 0.99:1 |
| SliderMinimalPerf.default | 1392 | 1401 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 966 | 981 | 0.98:1 |
| LabelMinimalPerf.default | 309 | 316 | 0.98:1 |
| ListNestedPerf.default | 449 | 457 | 0.98:1 |
| RosterPerf.default | 844 | 863 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1030 | 1046 | 0.98:1 |
| EmbedMinimalPerf.default | 3300 | 3394 | 0.97:1 |
| LoaderMinimalPerf.default | 565 | 585 | 0.97:1 |
| SplitButtonMinimalPerf.default | 3598 | 3707 | 0.97:1 |
| VideoMinimalPerf.default | 526 | 543 | 0.97:1 |
| CheckboxMinimalPerf.default | 2144 | 2222 | 0.96:1 |
| InputMinimalPerf.default | 1043 | 1084 | 0.96:1 |
| AccordionMinimalPerf.default | 108 | 114 | 0.95:1 |
| AlertMinimalPerf.default | 203 | 218 | 0.93:1 |
| DropdownManyItemsPerf.default | 528 | 566 | 0.93:1 |
| TooltipMinimalPerf.default | 859 | 935 | 0.92:1 |
| ListCommonPerf.default | 460 | 508 | 0.91:1 |
| CardMinimalPerf.default | 413 | 457 | 0.9:1 |
| CarouselMinimalPerf.default | 338 | 394 | 0.86:1 |
| ListWith60ListItems.default | 434 | 504 | 0.86:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 772 | 790 | 5000 | |
| Breadcrumb | mount | 2356 | 2367 | 1000 | |
| Checkbox | mount | 1280 | 1278 | 5000 | |
| CheckboxBase | mount | 1084 | 1105 | 5000 | |
| ChoiceGroup | mount | 4055 | 4022 | 5000 | |
| ComboBox | mount | 844 | 843 | 1000 | |
| CommandBar | mount | 9154 | 9119 | 1000 | |
| ContextualMenu | mount | 10091 | 10186 | 1000 | |
| DefaultButton | mount | 974 | 984 | 5000 | |
| DetailsRow | mount | 3295 | 3353 | 5000 | |
| DetailsRowFast | mount | 3293 | 3384 | 5000 | |
| DetailsRowNoStyles | mount | 3156 | 3156 | 5000 | |
| Dialog | mount | 1947 | 1940 | 1000 | |
| DocumentCardTitle | mount | 161 | 147 | 1000 | |
| Dropdown | mount | 3077 | 2841 | 5000 | |
| FocusTrapZone | mount | 1625 | 1571 | 5000 | |
| FocusZone | mount | 1560 | 1582 | 5000 | |
| IconButton | mount | 1488 | 1506 | 5000 | |
| Label | mount | 292 | 299 | 5000 | |
| Layer | mount | 2522 | 2503 | 5000 | |
| Link | mount | 392 | 396 | 5000 | |
| MenuButton | mount | 1269 | 1258 | 5000 | |
| MessageBar | mount | 1854 | 1865 | 5000 | |
| Nav | mount | 2902 | 2844 | 1000 | |
| OverflowSet | mount | 928 | 959 | 5000 | |
| Panel | mount | 1900 | 1914 | 1000 | |
| Persona | mount | 865 | 885 | 1000 | |
| Pivot | mount | 1251 | 1272 | 1000 | |
| PrimaryButton | mount | 1120 | 1148 | 5000 | |
| Rating | mount | 6715 | 6649 | 5000 | |
| SearchBox | mount | 1103 | 1122 | 5000 | |
| Shimmer | mount | 2133 | 2146 | 5000 | |
| Slider | mount | 1650 | 1652 | 5000 | |
| SpinButton | mount | 4357 | 4384 | 5000 | |
| Spinner | mount | 377 | 367 | 5000 | |
| SplitButton | mount | 2743 | 2741 | 5000 | |
| Stack | mount | 457 | 448 | 5000 | |
| StackWithIntrinsicChildren | mount | 1969 | 1930 | 5000 | |
| StackWithTextChildren | mount | 4493 | 4496 | 5000 | |
| SwatchColorPicker | mount | 10037 | 10039 | 5000 | |
| TagPicker | mount | 2333 | 2402 | 5000 | |
| TeachingBubble | mount | 86968 | 86551 | 5000 | |
| Text | mount | 356 | 366 | 5000 | |
| TextField | mount | 1220 | 1233 | 5000 | |
| ThemeProvider | mount | 1031 | 1015 | 5000 | |
| ThemeProvider | virtual-rerender | 550 | 556 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1640 | 1616 | 5000 | |
| Toggle | mount | 696 | 681 | 5000 | |
| buttonNative | mount | 115 | 106 | 5000 |
ling1726
commented
Jun 7, 2022
Comment on lines
+20
to
+21
| "e2e": "yarn cypress run --component", | ||
| "e2e:local": "yarn cypress open --component", |
There was a problem hiding this comment.
now that configs are extendable, we can simply use the native binary
ling1726
commented
Jun 7, 2022
| config.rootDir && `integrationFolder=${config.rootDir}`, | ||
| config.testNamePattern && `testFiles=${config.testNamePattern}`, | ||
| ].filter(Boolean); | ||
| const configArguments = [`baseUrl=${config.serverUrl}`].filter(Boolean); |
There was a problem hiding this comment.
the removed arguments were never used and now also no longer supported by v10
layershifter
reviewed
Jun 7, 2022
change/@fluentui-react-2f53b9f6-dfb1-4bc5-bde8-648d91f1dded.json
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2022
change/@fluentui-react-card-cb431b04-92ad-4928-ae7c-7d1fa13d8021.json
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 7, 2022
| @@ -26,14 +26,14 @@ | |||
| "check:change": "beachball check", | |||
| "check:modified-files": "yarn workspace @fluentui/scripts just check-for-modified-files", | |||
| "check:affected-package": "node ./scripts/monorepo/checkIfPackagesAffected.js", | |||
| "check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/web-components|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react\"", | |||
| "check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/web-components|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react|cypress\"", | |||
There was a problem hiding this comment.
It's a bit scary taking into account this dmtrKovalenko/cypress-real-events#259
There was a problem hiding this comment.
The package itself is simple enough that if it is no longer maintained we can copy it, we want real CDP events for sure
layershifter
reviewed
Jun 7, 2022
layershifter
approved these changes
Jun 7, 2022
It might be for the M1 only 🤣(CI below)
|
andrefcdias
approved these changes
Jun 7, 2022
change/@fluentui-react-menu-b71dc5b0-0f29-47a4-9f8e-00e564852313.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-popover-f29a77e6-85cc-40c6-b1f8-d79ce4323ef1.json
Outdated
Show resolved
Hide resolved
change/@fluentui-react-tabster-741540b1-91bb-4a96-9939-9c49bc6491d9.json
Outdated
Show resolved
Hide resolved
|
ling1726
commented
Jun 7, 2022
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "extends": "../tsconfig.json", | |||
There was a problem hiding this comment.
cypress uses chai as an assertion engine. Need a specific tsconfig for tests here. Fix courtesy of @Hotell
khmakoto
approved these changes
Jun 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jun 8, 2022
Following microsoft#23435, adds an extended cypress config to test the babel preset for global context
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Jun 8, 2022
Following microsoft#23435, adds an extended cypress config in babel-preset-global-context with tests.
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* chore: Bump cypress to v10 Bumps cypress to [latest major v10](https://docs.cypress.io/guides/references/changelog#10-0-0) which introduces code config (`cypress.config.ts`). Done for both v9 and northstar. * update CI command * changefiles * update package.json * new e2e:local command * remove cypress plugins * update generator * fix script types * remove unnecessary deps * fix changefiles * fix gulp
ling1726
added a commit
that referenced
this pull request
Jun 13, 2022
* chore: Add tests for babel-preset-global-context Following #23435, adds an extended cypress config in babel-preset-global-context with tests. * add pre script to build * scope babel-prest-global-context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps cypress to latest major v10 which introduces code config (
cypress.config.ts).Overview of the breaking changes between v9 and v10
cypress.jsonis no longer supported - usecypress.config.tspluginsare no longer configured through a separate entrypointcypress.config.tsfiles are extendable throughimportDone for both v9 and northstar.