Update API Extractor version #18885
Closed
Update API Extractor version #18885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrefcdias
added
Area: Build System
dependencies
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6db5bb3:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6ebcc1f:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FocusZone | mount | 1870 | 1850 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 890 | 882 | 5000 | |
| BaseButton | mount | 994 | 976 | 5000 | |
| Breadcrumb | mount | 2669 | 2699 | 1000 | |
| ButtonNext | mount | 611 | 592 | 5000 | |
| Checkbox | mount | 1649 | 1697 | 5000 | |
| CheckboxBase | mount | 1426 | 1412 | 5000 | |
| ChoiceGroup | mount | 5127 | 5251 | 5000 | |
| ComboBox | mount | 1065 | 1050 | 1000 | |
| CommandBar | mount | 10669 | 10559 | 1000 | |
| ContextualMenu | mount | 6398 | 6336 | 1000 | |
| DefaultButton | mount | 1207 | 1213 | 5000 | |
| DetailsRow | mount | 3930 | 4011 | 5000 | |
| DetailsRowFast | mount | 3890 | 3948 | 5000 | |
| DetailsRowNoStyles | mount | 3774 | 3960 | 5000 | |
| Dialog | mount | 2298 | 2294 | 1000 | |
| DocumentCardTitle | mount | 163 | 158 | 1000 | |
| Dropdown | mount | 3502 | 3496 | 5000 | |
| FluentProviderNext | mount | 7185 | 7046 | 5000 | |
| FocusTrapZone | mount | 1910 | 1851 | 5000 | |
| FocusZone | mount | 1870 | 1850 | 5000 | Possible regression |
| IconButton | mount | 1907 | 1938 | 5000 | |
| Label | mount | 352 | 362 | 5000 | |
| Layer | mount | 1930 | 1977 | 5000 | |
| Link | mount | 487 | 491 | 5000 | |
| MakeStyles | mount | 1833 | 1819 | 50000 | |
| MenuButton | mount | 1609 | 1602 | 5000 | |
| MessageBar | mount | 2093 | 2123 | 5000 | |
| Nav | mount | 3465 | 3494 | 1000 | |
| OverflowSet | mount | 1141 | 1157 | 5000 | |
| Panel | mount | 2254 | 2165 | 1000 | |
| Persona | mount | 862 | 921 | 1000 | |
| Pivot | mount | 1479 | 1538 | 1000 | |
| PrimaryButton | mount | 1377 | 1465 | 5000 | |
| Rating | mount | 8444 | 8426 | 5000 | |
| SearchBox | mount | 1435 | 1437 | 5000 | |
| Shimmer | mount | 2758 | 2809 | 5000 | |
| Slider | mount | 2075 | 2105 | 5000 | |
| SpinButton | mount | 5366 | 5306 | 5000 | |
| Spinner | mount | 450 | 447 | 5000 | |
| SplitButton | mount | 3472 | 3423 | 5000 | |
| Stack | mount | 594 | 565 | 5000 | |
| StackWithIntrinsicChildren | mount | 1732 | 1731 | 5000 | |
| StackWithTextChildren | mount | 5126 | 5053 | 5000 | |
| SwatchColorPicker | mount | 10897 | 11025 | 5000 | |
| Tabs | mount | 1505 | 1502 | 1000 | |
| TagPicker | mount | 2659 | 2688 | 5000 | |
| TeachingBubble | mount | 12550 | 12357 | 5000 | |
| Text | mount | 463 | 475 | 5000 | |
| TextField | mount | 1515 | 1557 | 5000 | |
| ThemeProvider | mount | 1247 | 1244 | 5000 | |
| ThemeProvider | virtual-rerender | 640 | 616 | 5000 | |
| Toggle | mount | 920 | 858 | 5000 | |
| buttonNative | mount | 124 | 127 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 238 | 214 | 1.11:1 |
| SkeletonMinimalPerf.default | 430 | 388 | 1.11:1 |
| HeaderMinimalPerf.default | 419 | 380 | 1.1:1 |
| DividerMinimalPerf.default | 421 | 386 | 1.09:1 |
| PortalMinimalPerf.default | 194 | 178 | 1.09:1 |
| SegmentMinimalPerf.default | 393 | 369 | 1.07:1 |
| AnimationMinimalPerf.default | 467 | 441 | 1.06:1 |
| BoxMinimalPerf.default | 392 | 369 | 1.06:1 |
| ListMinimalPerf.default | 564 | 534 | 1.06:1 |
| FormMinimalPerf.default | 465 | 442 | 1.05:1 |
| RefMinimalPerf.default | 254 | 241 | 1.05:1 |
| VideoMinimalPerf.default | 730 | 696 | 1.05:1 |
| AccordionMinimalPerf.default | 164 | 158 | 1.04:1 |
| ButtonMinimalPerf.default | 195 | 188 | 1.04:1 |
| ButtonOverridesMissPerf.default | 1860 | 1780 | 1.04:1 |
| DatepickerMinimalPerf.default | 5880 | 5650 | 1.04:1 |
| HeaderSlotsPerf.default | 849 | 813 | 1.04:1 |
| AttachmentSlotsPerf.default | 1161 | 1131 | 1.03:1 |
| ButtonSlotsPerf.default | 605 | 588 | 1.03:1 |
| LayoutMinimalPerf.default | 399 | 389 | 1.03:1 |
| MenuMinimalPerf.default | 934 | 905 | 1.03:1 |
| ToolbarMinimalPerf.default | 1046 | 1017 | 1.03:1 |
| CardMinimalPerf.default | 623 | 610 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 318 | 311 | 1.02:1 |
| ImageMinimalPerf.default | 438 | 431 | 1.02:1 |
| LabelMinimalPerf.default | 424 | 417 | 1.02:1 |
| RadioGroupMinimalPerf.default | 478 | 468 | 1.02:1 |
| SliderMinimalPerf.default | 1687 | 1647 | 1.02:1 |
| StatusMinimalPerf.default | 738 | 726 | 1.02:1 |
| TableMinimalPerf.default | 469 | 460 | 1.02:1 |
| TreeMinimalPerf.default | 857 | 837 | 1.02:1 |
| ChatWithPopoverPerf.default | 398 | 395 | 1.01:1 |
| DropdownMinimalPerf.default | 3204 | 3180 | 1.01:1 |
| GridMinimalPerf.default | 360 | 358 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1338 | 1320 | 1.01:1 |
| ListNestedPerf.default | 608 | 602 | 1.01:1 |
| IconMinimalPerf.default | 680 | 672 | 1.01:1 |
| TextMinimalPerf.default | 384 | 380 | 1.01:1 |
| CustomToolbarPrototype.default | 4064 | 4014 | 1.01:1 |
| DropdownManyItemsPerf.default | 764 | 767 | 1:1 |
| EmbedMinimalPerf.default | 4352 | 4352 | 1:1 |
| InputMinimalPerf.default | 1308 | 1303 | 1:1 |
| LoaderMinimalPerf.default | 731 | 732 | 1:1 |
| PopupMinimalPerf.default | 606 | 606 | 1:1 |
| ProviderMergeThemesPerf.default | 1680 | 1673 | 1:1 |
| ReactionMinimalPerf.default | 415 | 416 | 1:1 |
| SplitButtonMinimalPerf.default | 4123 | 4128 | 1:1 |
| TooltipMinimalPerf.default | 1088 | 1084 | 1:1 |
| AlertMinimalPerf.default | 301 | 303 | 0.99:1 |
| CarouselMinimalPerf.default | 510 | 516 | 0.99:1 |
| CheckboxMinimalPerf.default | 2934 | 2954 | 0.99:1 |
| DialogMinimalPerf.default | 808 | 817 | 0.99:1 |
| FlexMinimalPerf.default | 307 | 310 | 0.99:1 |
| ListCommonPerf.default | 691 | 695 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1754 | 1773 | 0.99:1 |
| ProviderMinimalPerf.default | 1050 | 1059 | 0.99:1 |
| TextAreaMinimalPerf.default | 576 | 581 | 0.99:1 |
| AttachmentMinimalPerf.default | 169 | 173 | 0.98:1 |
| ListWith60ListItems.default | 692 | 705 | 0.98:1 |
| RosterPerf.default | 1294 | 1324 | 0.98:1 |
| TableManyItemsPerf.default | 2098 | 2227 | 0.94:1 |
| ChatMinimalPerf.default | 683 | 731 | 0.93:1 |
| TreeWith60ListItems.default | 182 | 195 | 0.93:1 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 035ba0498cee783b11b31dffa0cbf595b73d6ec8 (build) |
ecraig12345
reviewed
Jul 13, 2021
| @@ -26007,6 +26057,11 @@ typescript@~3.7.2: | |||
| resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.2.tgz#27e489b95fa5909445e9fef5ee48d81697ad18fb" | |||
| integrity sha512-ml7V7JfiN2Xwvcer+XAf2csGO1bPBdRbFCkYBczNZggrBZ9c7G3riSUeJmqEU5uOtXNPMhE3n+R4FA/3YOAWOQ== | |||
|
|
|||
| typescript@~4.3.2: | |||
There was a problem hiding this comment.
This is probably being pulled in because API Extractor is tied to a specific TS version, which means that we'd be generating API docs and compiling with different versions (which is very likely to cause issues at some point). I'm curious what happens if we force API Extractor to resolve to TS 4.1.5 instead.
ecraig12345
reviewed
Jul 13, 2021
| @@ -28,8 +28,8 @@ | |||
| "@fluentui/style-utilities": "^8.2.0", | |||
| "@fluentui/theme": "^2.1.4", | |||
| "@fluentui/utilities": "^8.2.1", | |||
| "@microsoft/api-extractor-model": "7.12.1", | |||
| "@microsoft/tsdoc": "0.12.24", | |||
| "@microsoft/api-extractor-model": "^7.13.4", | |||
There was a problem hiding this comment.
This should be 7.13.3 (specifically) to avoid a duplicate.
1 task
|
Closing this in favor of #18920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
- Addresses an existing issue: Fixes #0000$ yarn changeDescription of changes
import * as module from './local/module'statements.react-menudocumentation from @see (block tag) to @link (inline tag)Required for #18778 implementation.