[web-components] refactor color recipes for DI #18199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 166aff3:
|
nicholasrice
approved these changes
May 14, 2021
EisenbergEffect
approved these changes
May 14, 2021
There was a problem hiding this comment.
My only comments are that there's a large amount of what appears to be duplicative code with fast-components. Should any of this be moved into foundation? Some of it seems like primitives e.g. Palette. Also, what was our reason for making the recipes internal? Is that a temporary thing that we plan to lift after we work out a few more things?
| @@ -0,0 +1,32 @@ | |||
| # FAST Color Recipes | |||
There was a problem hiding this comment.
Suggested change
| # FAST Color Recipes | |
| # FluentUI Color Recipes |
| @@ -0,0 +1,32 @@ | |||
| # FAST Color Recipes | |||
|
|
|||
| Color recipes are named colors who's value is algorithmically defined from a variety of inputs. `@microsoft/fast-components` relies on these recipes heavily to achieve expressive theming options while maintaining color accessability targets. | |||
There was a problem hiding this comment.
Suggested change
| Color recipes are named colors who's value is algorithmically defined from a variety of inputs. `@microsoft/fast-components` relies on these recipes heavily to achieve expressive theming options while maintaining color accessability targets. | |
| Color recipes are named colors who's value is algorithmically defined from a variety of inputs. `@fluentui/web-components` relies on these recipes heavily to achieve expressive theming options while maintaining color accessibility targets. |
| **Example: Creating a SwatchRGB** | ||
|
|
||
| ```ts | ||
| import { SwatchRGB } from '@microsoft/fast-components'; |
There was a problem hiding this comment.
Suggested change
| import { SwatchRGB } from '@microsoft/fast-components'; | |
| import { SwatchRGB } from '@fluentui/web-components'; |
chrisdholt
force-pushed
the
users/chhol/refactor-color-recipes-for-di
branch
from
bbec96d
to
166aff3
Compare
chrisdholt
added a commit
that referenced
this pull request
May 14, 2021
* add color-vNext folder with recipes and update specs * Change files
chrisdholt
added a commit
that referenced
this pull request
May 18, 2021
* add color-vNext folder with recipes and update specs * Change files
chrisdholt
added a commit
that referenced
this pull request
Jun 8, 2021
* add color-vNext folder with recipes and update specs * Change files
chrisdholt
added a commit
that referenced
this pull request
Jul 2, 2021
* add color-vNext folder with recipes and update specs * Change files
chrisdholt
added a commit
that referenced
this pull request
Jul 2, 2021
* add color-vNext folder with recipes and update specs * Change files
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
* add color-vNext folder with recipes and update specs * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Creates vNext color recipes and updates tests to ensure parity.
Focus areas to test
(optional)