Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting FluentHorizontalScroll #17470

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Exporting FluentHorizontalScroll #17470

merged 2 commits into from
Mar 18, 2021

Conversation

robarbms
Copy link
Contributor

@robarbms robarbms commented Mar 17, 2021 •
edited
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Missed fluent library export of Horizontal Scroll and styles.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 17, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50f9eeb:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 17, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 82ad36f0e3a6d8f00f6dc99638d58a0f7a018e80 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 17, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1205 1189 5000
BaseButton mount 922 878 5000
Breadcrumb mount 44472 43969 5000
ButtonNext mount 1179 1253 5000
Checkbox mount 1550 1547 5000
CheckboxBase mount 1318 1287 5000
ChoiceGroup mount 4841 4779 5000
ComboBox mount 972 1029 1000
CommandBar mount 10457 10299 1000
ContextualMenu mount 6452 6316 1000
DefaultButton mount 1220 1230 5000
DetailsRow mount 3742 3687 5000
DetailsRowFast mount 3938 3833 5000
DetailsRowNoStyles mount 3429 3464 5000
Dialog mount 1541 1534 1000
DocumentCardTitle mount 1876 1943 1000
Dropdown mount 3397 3377 5000
FocusTrapZone mount 1871 1835 5000
FocusZone mount 1811 1879 5000
IconButton mount 1791 1722 5000
Label mount 332 353 5000
Layer mount 1857 1854 5000
Link mount 460 498 5000
MakeStyles mount 1985 2006 50000
MenuButton mount 1519 1513 5000
MessageBar mount 1998 2075 5000
Nav mount 3359 3240 1000
OverflowSet mount 1017 1052 5000
Panel mount 1416 1443 1000
Persona mount 816 809 1000
Pivot mount 1519 1430 1000
PrimaryButton mount 1336 1337 5000
Rating mount 7780 7583 5000
SearchBox mount 1431 1300 5000
Shimmer mount 2519 2788 5000
Slider mount 1968 2081 5000
SpinButton mount 5144 5164 5000
Spinner mount 422 448 5000
SplitButton mount 3284 3198 5000
Stack mount 542 488 5000
StackWithIntrinsicChildren mount 1609 1599 5000
StackWithTextChildren mount 4701 4752 5000
SwatchColorPicker mount 10402 10748 5000
Tabs mount 1412 1511 1000
TagPicker mount 2758 2878 5000
TeachingBubble mount 12112 11995 5000
Text mount 469 413 5000
TextField mount 1483 1430 5000
ThemeProvider mount 1199 1229 5000
ThemeProvider virtual-rerender 646 585 5000
ThemeProviderNext mount 16425 16602 5000
Toggle mount 868 870 5000
buttonNative mount 113 113 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.47 0.36:1 2000 349
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 621
🔧 Checkbox.Fluent 0.66 0.37 1.78:1 1000 658
🎯 Dialog.Fluent 0.16 0.22 0.73:1 5000 808
🔧 Dropdown.Fluent 3.21 0.42 7.64:1 1000 3205
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 712
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 396
🔧 Slider.Fluent 1.65 0.47 3.51:1 1000 1649
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 403
🦄 Tooltip.Fluent 0.15 0.92 0.16:1 5000 756

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 446 370 1.21:1
ChatMinimalPerf.default 774 661 1.17:1
CarouselMinimalPerf.default 571 495 1.15:1
TableMinimalPerf.default 488 427 1.14:1
AlertMinimalPerf.default 338 308 1.1:1
HeaderSlotsPerf.default 871 794 1.1:1
AvatarMinimalPerf.default 221 202 1.09:1
ItemLayoutMinimalPerf.default 1369 1257 1.09:1
Tooltip.Fluent 756 693 1.09:1
RefMinimalPerf.default 270 252 1.07:1
AccordionMinimalPerf.default 181 170 1.06:1
CardMinimalPerf.default 603 568 1.06:1
DropdownManyItemsPerf.default 794 751 1.06:1
TableManyItemsPerf.default 2184 2055 1.06:1
TextMinimalPerf.default 412 389 1.06:1
TextAreaMinimalPerf.default 515 487 1.06:1
ToolbarMinimalPerf.default 1053 997 1.06:1
AttachmentMinimalPerf.default 181 172 1.05:1
ChatDuplicateMessagesPerf.default 349 332 1.05:1
ReactionMinimalPerf.default 448 427 1.05:1
VideoMinimalPerf.default 737 699 1.05:1
ChatWithPopoverPerf.default 403 387 1.04:1
ImageMinimalPerf.default 409 395 1.04:1
ListMinimalPerf.default 539 519 1.04:1
ListWith60ListItems.default 696 667 1.04:1
MenuMinimalPerf.default 981 942 1.04:1
Button.Fluent 621 599 1.04:1
Slider.Fluent 1649 1592 1.04:1
CheckboxMinimalPerf.default 3201 3117 1.03:1
SkeletonMinimalPerf.default 395 382 1.03:1
SplitButtonMinimalPerf.default 3935 3815 1.03:1
DatepickerMinimalPerf.default 50092 49748 1.01:1
DialogMinimalPerf.default 844 836 1.01:1
EmbedMinimalPerf.default 4422 4383 1.01:1
HeaderMinimalPerf.default 399 395 1.01:1
MenuButtonMinimalPerf.default 1681 1660 1.01:1
PortalMinimalPerf.default 187 186 1.01:1
SliderMinimalPerf.default 1719 1694 1.01:1
TreeWith60ListItems.default 202 200 1.01:1
Avatar.Fluent 349 345 1.01:1
AnimationMinimalPerf.default 465 464 1:1
ButtonUseCssNestingPerf.default 1174 1172 1:1
FlexMinimalPerf.default 335 334 1:1
FormMinimalPerf.default 433 434 1:1
RadioGroupMinimalPerf.default 457 456 1:1
Text.Fluent 403 401 1:1
ButtonOverridesMissPerf.default 1760 1770 0.99:1
ButtonUseCssPerf.default 878 887 0.99:1
LayoutMinimalPerf.default 450 454 0.99:1
ListCommonPerf.default 705 715 0.99:1
AttachmentSlotsPerf.default 1195 1221 0.98:1
DropdownMinimalPerf.default 3288 3344 0.98:1
ProviderMergeThemesPerf.default 1676 1718 0.98:1
CustomToolbarPrototype.default 3936 4021 0.98:1
ButtonSlotsPerf.default 644 661 0.97:1
GridMinimalPerf.default 369 382 0.97:1
InputMinimalPerf.default 1327 1367 0.97:1
ProviderMinimalPerf.default 995 1022 0.97:1
DividerMinimalPerf.default 413 431 0.96:1
PopupMinimalPerf.default 727 759 0.96:1
SegmentMinimalPerf.default 363 380 0.96:1
StatusMinimalPerf.default 743 771 0.96:1
TreeMinimalPerf.default 776 806 0.96:1
Dialog.Fluent 808 844 0.96:1
TooltipMinimalPerf.default 976 1033 0.94:1
Image.Fluent 396 420 0.94:1
ListNestedPerf.default 576 621 0.93:1
LoaderMinimalPerf.default 746 799 0.93:1
Dropdown.Fluent 3205 3473 0.92:1
LabelMinimalPerf.default 444 487 0.91:1
IconMinimalPerf.default 684 753 0.91:1
RosterPerf.default 1114 1237 0.9:1
Checkbox.Fluent 658 733 0.9:1
Icon.Fluent 712 788 0.9:1
ButtonMinimalPerf.default 199 223 0.89:1

@chrisdholt chrisdholt merged commit 02cfbd8 into microsoft:master Mar 18, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Mar 25, 2021
@robarbms @joshualamusga1
Exporting FluentHorizontalScroll (microsoft#17470)
0270df0 
* Exporting FluentHorizontalScroll

* Change files
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@robarbms @miroslavstastny
Exporting FluentHorizontalScroll (microsoft#17470)
1f0848e 
* Exporting FluentHorizontalScroll

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdholt chrisdholt chrisdholt approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@khmakoto khmakoto

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robarbms @fabricteam @msft-fluent-ui-bot @EisenbergEffect @chrisdholt @khmakoto