Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all web components leverage the body font variable #16013

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Ensure all web components leverage the body font variable #16013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708920b
ensure all web components leverage the body font design token
chrisdholt Nov 19, 2020
9541c0a
Change files
chrisdholt Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ponents-2020-11-19-15-28-31-users-chhol-ensure-all-components-leverage-body-font-var.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "ensure all web components leverage the body font design token",
"packageName": "@fluentui/web-components",
"email": "[email protected]",
"dependentChangeType": "patch",
"date": "2020-11-19T23:28:31.598Z"
}
1 change: 1 addition & 0 deletions packages/web-components/src/menu-item/menu-item.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const MenuItemStyles = css`
color: ${neutralForegroundRestBehavior.var};
fill: ${neutralForegroundRestBehavior.var};
cursor: pointer;
font-family: var(--body-font);
font-size: var(--type-ramp-base-font-size);
line-height: var(--type-ramp-base-line-height);
border-radius: calc(var(--corner-radius) * 1px);
Expand Down
1 change: 1 addition & 0 deletions packages/web-components/src/slider-label/slider-label.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { heightNumber, neutralOutlineRestBehavior } from '../styles';

export const SliderLabelStyles = css`
${display('block')} :host {
font-family: var(--body-font);
}
.root {
position: absolute;
Expand Down
1 change: 1 addition & 0 deletions packages/web-components/src/text-field/text-field.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export const TextFieldStyles = css`
border: none;
padding: 0 calc(var(--design-unit) * 2px + 1px);
color: ${neutralForegroundRestBehavior.var};
font-family: inherit;
font-size: var(--type-ramp-base-font-size);
line-height: var(--type-ramp-base-line-height);
}
Expand Down