Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical stacked bar chart combined callout and other tweaks #14912

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Vertical stacked bar chart combined callout and other tweaks #14912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c30092
Vertical stacked bar chart combined callout and other tweaks
mbest Sep 4, 2020
a98015f
Change files
mbest Sep 4, 2020
d230b07
changing to "major" due to removed exports (internal state interface …
mbest Sep 9, 2020
14a5f18
Merge remote-tracking branch 'upstream/master' into VerticalStackedBa…
mbest Sep 9, 2020
da41823
maintain earlier update
mbest Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../@uifabric-charting-2020-09-04-14-12-33-VerticalStackedBarChart-callout-improvements.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "major",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this should NOT have been a major change. Major version bumps should be reserved for backwards-incompatible API changes, which I don't think I'm seeing in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raghurk wanted it to be major due to the changes to IVerticalStackedBarChartState, which had previously been exported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, talked to @Raghurk and he said this was intentional

"comment": "Vertical stacked bar chart combined callout and other tweaks",
"packageName": "@uifabric/charting",
"email": "[email protected]",
"dependentChangeType": "patch",
"date": "2020-09-04T21:12:33.817Z"
}
Loading