Fix BasePicker's onDismiss behavior from changing if getTextFromItem provided #14302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0a75b6:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changes
Baseline commit: f2c29686e5fb0d71db3a1e02ee4a7f3fdc185d03 (build) |
17jlee2
changed the title
@xugao @joschect Hey! I'm not very familiar with the workflow here. Is the recommendation saying to update my fork with the main repo, to create another PR, or something else entirely? |
xugao
reviewed
Aug 10, 2020
packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
Outdated
Show resolved
Hide resolved
|
if you pull master again , the size auditor error should go away
|
merge master
I think I understand, thanks! |
joschect
reviewed
Aug 11, 2020
packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/pickers/BasePicker.types.ts
Show resolved
Hide resolved
joschect
approved these changes
Aug 11, 2020
|
🎉 Handy links: |
levithomason
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Aug 24, 2020
…provided (microsoft#14302) * BasePicker's onDismiss can now return a boolean to decide if an item is selected * fixed a typo Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
getTextFromItemchanges dismiss behavior #10892$ yarn changeDescription of changes
As suggested in #10892, this changes the return type of the BasePicker's onDismiss prop to optionally return a boolean. If it returns false, then the first suggested item is not selected when the suggestions callout is dismissed. If it returns anything else, then the default behavior of it selecting the first suggestion is preserved.
Focus areas to test
The BasePicker and its derivatives (like TagPicker)