Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align react-components Exports with Sub-package Exports #23345

Closed
spmonahan opened this issue May 31, 2022 · 2 comments
Closed

Align react-components Exports with Sub-package Exports #23345

spmonahan opened this issue May 31, 2022 · 2 comments

Comments

@spmonahan
Copy link
Contributor

Problem

Because @fluentui/react-components does not always re-export all of the functionality of the sub-packages from which it is composed it can lack feature parity with its sub-packages.

For example, @fluentui/react-utilities provides a useMount() hook that is not re-exported from @fluentui/react-components meaning a user directly depending on react-utilities has access to more features than one depending on react-components.

Appetite

3~4 weeks. We should have a solution prior to the release of v9 stable at the end of June.

Solution

All features that are part of the public API of any of @fluentui/react-components' sub-packages should also be part of @fluentui/react-components' public API.

Risks (Rabbit holes)

Out of scope (No-gos)

  1. No breaking changes

Related

@spmonahan spmonahan changed the title Align react-components exports with sub-package exports Align react-components Exports with Sub-package Exports May 31, 2022
@layershifter
Copy link
Member

@spmonahan is it still a thing? Can you please close it if not?

@spmonahan
Copy link
Contributor Author

I think the linked issue covers this and it has all the updates with the work being done so I'll close this one.

Repository owner moved this from Todo to Done in @fluentui/react-components v9.0.0 Aug 8, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants