Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Annotate Sub-Package Exports As "Internal" #23343

Open
3 of 6 tasks
spmonahan opened this issue May 31, 2022 · 2 comments
Open
3 of 6 tasks

Add Ability to Annotate Sub-Package Exports As "Internal" #23343

spmonahan opened this issue May 31, 2022 · 2 comments

Comments

@spmonahan
Copy link
Contributor

spmonahan commented May 31, 2022

Problem

The @fluentui/react-components package represents the officially supported public API surface of Fluent UI React v9 yet it is composed on many "sub-packages" that are published on npm and follow semantic versioning, effectively making the APIs of these sub-packages part of Fluent's public API as well. Yet we don't always re-export an entire sub-package's API from @fluentui/react-components as parts of these APIs are meant for internal use only.

For example, @fluentui/react-components imports @fluentui/react-utilities and then re-exports some of its exports. Some of the exports from react-utilities are only meant for internal use and are not part of the public API but we have no way of communicating this to users our even within the Fluent UI team.

Appetite

3~4 weeks. We should have a solution prior to the release of v9 stable at the end of June.

Solution

Provide a mechanism to mark exports from a sub-package as "internal only".

Risks (Rabbit holes)

Out of scope (No-gos)

  1. No breaking changes allowed

Related

Tasks

@spmonahan spmonahan changed the title Annotate Sub-Package Exports As "Internal" Add Ability to Annotate Sub-Package Exports As "Internal" May 31, 2022
@Hotell Hotell added this to the June Project Cycle Q2 2022 milestone Jun 8, 2022
@Hotell Hotell removed this from the June Project Cycle Q2 2022 milestone Sep 12, 2022
@Hotell Hotell mentioned this issue Nov 2, 2022
28 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 28, 2024

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes.
Still require assistance? Please add comment - "keep open".

@Hotell
Copy link
Contributor

Hotell commented Aug 29, 2024

"keep open"

we won't implement this in upcoming quarter/s - but will keep it open as we wanna get this functionality eventually

@Hotell Hotell removed Priority 2: Normal Resolution: Soft Close Soft closing inactive issues over a certain period labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants