Skip to content

Commit

Permalink
Upgrade to Rush 5 (#6242)
Browse files Browse the repository at this point in the history
* Upgrade config files to Rush 5 syntax

* rush update

* Start updating scripts to avoid a phantom node_modules folder in the repository root

* update rush version

* update lint-staged to ignore common/scripts

* add hooks

* update shrinkwrap

* update snapshots

* update experiments snapshot

* change files

* update snapshots

* add tslib as a dependency in dashboard

* dashboard change file

* update DatePicker snapshots

* add apps/vr-tests/** to ignore of lint-staged

* add newline

* should be rush update --full instead of --force

* generate runs with full and update runs without full

* change type to none for upgrading react-test-renderer

* add newline to package.json

* update to rush-update

* update SpinButton snapshot to remove undefined

* change file for prettier fixes in fabric-website
  • Loading branch information
natalieethell authored and micahgodbolt committed Sep 12, 2018
1 parent 19037b6 commit f425097
Show file tree
Hide file tree
Showing 271 changed files with 1,492 additions and 5,678 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ language: node_js
node_js:
- '8'
script:
- node common/scripts/install-run-rush.js install --bypass-policy
- if [ $TRAVIS_BRANCH == "master" ] && [ $TRAVIS_PULL_REQUEST != "false" ];
then npm run checkchange;
fi
Expand Down
149 changes: 64 additions & 85 deletions apps/fabric-website/src/pages/GetStarted/GetStartedPage.tsx

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/dashboard",
"comment": "add tslib as a dependency in dashboard",
"type": "patch"
}
],
"packageName": "@uifabric/dashboard",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "react-test-renderer version updated 16.4.2 -> 16.5.0",
"type": "none"
}
],
"packageName": "@uifabric/experiments",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/fabric-website",
"comment": "prettier fixes",
"type": "patch"
}
],
"packageName": "@uifabric/fabric-website",
"email": "[email protected]"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "react-test-renderer version updated 16.4.2 -> 16.5.0",
"type": "none"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
44 changes: 29 additions & 15 deletions common/config/rush/command-line.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,41 @@
{
"customCommands": [
"$schema": "https://developer.microsoft.com/json-schemas/rush/v5/command-line.schema.json",
"commands": [
{
"name": "code-style",
"summary": "Runs prettier and tslint.",
"documentation": "Runs prettier and tslint for each of the packages that have a code-style task.",
"parallelized": true
"commandKind": "bulk",
"description": "Runs prettier and tslint for each of the packages that have a code-style task.",
"enableParallelism": true
}
],
"customOptions": {
"--production": {
"optionType": "flag",
"parameters": [
{
"longName": "--production",
"parameterKind": "flag",
"description": "Builds production bits.",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
},
"--lint": {
"optionType": "flag",
{
"longName": "--lint",
"parameterKind": "flag",
"description": "Builds with linting.",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
},
"--npm-install-mode": {
"optionType": "flag",
{
"longName": "--npm-install-mode",
"parameterKind": "flag",
"description": "Skips tasks that are irrelevant during npm install",
"associatedCommands": ["build", "rebuild"]
"associatedCommands": [
"build",
"rebuild"
]
}
}
}
]
}
8 changes: 8 additions & 0 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/rush/v5/common-versions.schema.json",
"preferredVersions": {
"webpack": "3.11.0",
"webpack-dev-server": "2.11.2",
"webpack-cli": "2.0.15"
}
}
Loading

0 comments on commit f425097

Please sign in to comment.