GroupHeader: tighten typings (#8484)

* tighten newProps type * change file
microsoft · Mar 27, 2019 · 856dbd5 · 856dbd5
1 parent 5ad8b88
commit 856dbd5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/common/changes/office-ui-fabric-react/tightenGroupedListTypings_2019-03-26-21-04.json b/common/changes/office-ui-fabric-react/tightenGroupedListTypings_2019-03-26-21-04.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "office-ui-fabric-react",
+      "comment": "GroupHeader: tighten componentWillReceiveProps parameter typing",
+      "type": "patch"
+    }
+  ],
+  "packageName": "office-ui-fabric-react",
+  "email": "[email protected]"
+}
diff --git a/packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx b/packages/office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
@@ -31,15 +31,15 @@ export class GroupHeaderBase extends React.Component<IGroupHeaderProps, IGroupHe
     };
   }
 
-  public componentWillReceiveProps(newProps: any): void {
+  public componentWillReceiveProps(newProps: IGroupHeaderProps): void {
     if (newProps.group) {
       const newCollapsed = newProps.group.isCollapsed;
-      const isGroupLoading = newProps.headerProps && newProps.headerProps.isGroupLoading;
+      const isGroupLoading = newProps.isGroupLoading;
       const newLoadingVisible = !newCollapsed && isGroupLoading && isGroupLoading(newProps.group);
 
       this.setState({
-        isCollapsed: newCollapsed,
-        isLoadingVisible: newLoadingVisible
+        isCollapsed: newCollapsed || false,
+        isLoadingVisible: newLoadingVisible || false
       });
     }
   }