default spellCheck=false in BasePicker (#7301)

* make spellCheck defaults to false in BasePicker * rush change * updated snapshots * allowed inputProps to overwrite spellCheck
microsoft · Dec 6, 2018 · 2692f4a · 2692f4a
1 parent 0492281
commit 2692f4a
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 0 deletions.
diff --git a/common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json b/common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "office-ui-fabric-react",
+      "comment": "spellCheck defaults to false in BasePicker",
+      "type": "patch"
+    }
+  ],
+  "packageName": "office-ui-fabric-react",
+  "email": "[email protected]"
+}
diff --git a/...s/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot b/...s/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot
@@ -53,6 +53,7 @@ exports[`Component Examples renders PeoplePicker.Types.Example.tsx correctly 1`]
             onInput={[Function]}
             onKeyDown={[Function]}
             role="combobox"
+            spellCheck={false}
             value=""
           />
         </div>

diff --git a/...ages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot b/...ages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot
@@ -208,6 +208,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] =
             onInput={[Function]}
             onKeyDown={[Function]}
             role="combobox"
+            spellCheck={false}
             value=""
           />
         </div>
@@ -268,6 +269,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] =
             onInput={[Function]}
             onKeyDown={[Function]}
             role="combobox"
+            spellCheck={false}
             value=""
           />
         </div>

diff --git a/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx b/packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
@@ -205,6 +205,7 @@ export class BasePicker<T, P extends IBasePickerProps<T>> extends BaseComponent<
               </span>
               {this.canAddItems() && (
                 <Autofill
+                  spellCheck={false}
                   {...inputProps as any}
                   className={css('ms-BasePicker-input', styles.pickerInput, inputProps && inputProps.className)}
                   ref={this.input}

diff --git a/...ages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap b/...ages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap
@@ -51,6 +51,7 @@ exports[`Pickers BasePicker renders BasePicker correctly 1`] = `
           onInput={[Function]}
           onKeyDown={[Function]}
           role="combobox"
+          spellCheck={false}
           value=""
         />
       </div>
@@ -112,6 +113,7 @@ exports[`Pickers BasePicker renders BasePicker with inputProps supply classnames
           onKeyDown={[Function]}
           placeholder="Bitte einen Benutzer angeben..."
           role="combobox"
+          spellCheck={false}
           value=""
         />
       </div>
@@ -171,6 +173,7 @@ exports[`Pickers TagPicker renders TagPicker correctly 1`] = `
           onInput={[Function]}
           onKeyDown={[Function]}
           role="combobox"
+          spellCheck={false}
           value=""
         />
       </div>