Addressing PR feedback.

microsoft · Nov 9, 2022 · 06a4b01 · 06a4b01
1 parent 5898a24
commit 06a4b01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/packages/react-components/react-button/src/components/Button/useButtonStyles.ts b/packages/react-components/react-button/src/components/Button/useButtonStyles.ts
@@ -466,8 +466,6 @@ export const useButtonStyles_unstable = (state: ButtonState): ButtonState => {
     rootStyles[size],
     rootStyles[shape],
 
-    // Expanded styles
-
     // Disabled styles
     (disabled || disabledFocusable) && rootDisabledStyles.base,
     (disabled || disabledFocusable) && rootDisabledStyles.highContrast,

diff --git a/packages/react-components/react-button/src/components/ToggleButton/useToggleButtonStyles.ts b/packages/react-components/react-button/src/components/ToggleButton/useToggleButtonStyles.ts
@@ -215,19 +215,7 @@ const useRootDisabledStyles = makeStyles({
 
 const useIconCheckedStyles = makeStyles({
   // Appearance variations
-  outline: {
-    /* The outline styles are exactly the same as the base styles. */
-  },
-  primary: {
-    /* The primary styles are exactly the same as the base styles. */
-  },
-  secondary: {
-    /* The secondary styles are exactly the same as the base styles. */
-  },
-  subtle: {
-    color: tokens.colorNeutralForeground2BrandSelected,
-  },
-  transparent: {
+  subtleOrTransparent: {
     color: tokens.colorNeutralForeground2BrandSelected,
   },
 });
@@ -258,7 +246,7 @@ export const useToggleButtonStyles_unstable = (state: ToggleButtonState): Toggle
   if (state.icon) {
     state.icon.className = mergeClasses(
       toggleButtonClassNames.icon,
-      appearance && iconCheckedStyles[appearance],
+      (appearance === 'subtle' || appearance === 'transparent') && iconCheckedStyles.subtleOrTransparent,
       state.icon.className,
     );
   }