Fix: Lots of properties are not working in fluent-design-system-provider #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The units for these properties were incorrect and could not be applied even when values were set, due to the absence of measurement units:
px
. Therefore, it was decided to change their data type to string, allowing users to determine both the value and unit type as needed, while also maintaining consistency with the official FluentUI property types (ref: https://github.com/microsoft/fluentui/blob/57de08c18915440cdc54a1242bbdf948e2b0f562/packages/web-components/src/design-system-provider/index.ts#L426).For example, if the TypeRampMinus1FontSize property was assigned a value of float
12
, but did not include a unit such as "px" or "em", the value would not be applied correctly in the user interface. By changing the data type to string, users can now include the appropriate unit of measurement along with the value, providing greater flexibility in how the properties can be used.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps