Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template updates #447

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Template updates #447

merged 3 commits into from
Jun 12, 2023

Conversation

oneolddev
Copy link
Contributor

Pull Request

📖 Description

When creating a new fluent ui wasm project, FetchData.razor page generates nullable warnings on compile.

🎫 Issues

Warnings generated from code created from template.

Build started...
1>------ Build started: Project: fluentwasm, Configuration: Debug Any CPU ------
1>C:\git\fluentwasm\Pages\FetchData.razor(17,55,17,56): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(18,60,18,61): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(19,60,19,61): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(20,58,20,59): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(25,41,25,50): warning CS8618: Non-nullable field 'forecasts' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
1>C:\git\fluentwasm\Pages\FetchData.razor(17,55,17,56): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(18,60,18,61): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(19,60,19,61): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(20,58,20,59): warning CS8602: Dereference of a possibly null reference.
1>C:\git\fluentwasm\Pages\FetchData.razor(25,41,25,50): warning CS8618: Non-nullable field 'forecasts' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
1>fluentwasm -> C:\git\fluentwasm\bin\Debug\net7.0\fluentwasm.dll
1>fluentwasm (Blazor output) -> C:\git\fluentwasm\bin\Debug\net7.0\wwwroot
1>Done building project "fluentwasm.csproj".
1>fluentwasm -> C:\git\fluentwasm\bin\Debug\net6.0\fluentwasm.dll
1>fluentwasm (Blazor output) -> C:\git\fluentwasm\bin\Debug\net6.0\wwwroot
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
========== Build started at 1:58 PM and took 11.658 seconds ==========

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

When creating a new fluent ui wasm project, _FetchData.razor_ page generates nullable warnings on compile.
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do this for Server version as well?

@oneolddev
Copy link
Contributor Author

Can you do this for Server version as well?

No problem 🙂

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 12, 2023

Great, I'll merge it in once done. Thanks for your contribution!

@oneolddev
Copy link
Contributor Author

@vnbaaij

I also noticed in the *.csproj files

	<ItemGroup>
		<PackageReference Include="Microsoft.Fast.Components.FluentUI" Version="2.1.*" />
	</ItemGroup>

shouldn't this also be upgraded to

	<ItemGroup>
		<PackageReference Include="Microsoft.Fast.Components.FluentUI" Version="2.3.*" />
	</ItemGroup>

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 12, 2023

Yeah, that would be better indeed. Another commit?

@oneolddev
Copy link
Contributor Author

oneolddev commented Jun 12, 2023

@vnbaaij

One last find, Microsoft.Fast.Templates.FluentUI.csproj should have PackageVersion incremented.

@oneolddev
Copy link
Contributor Author

Yeah, that would be better indeed. Another commit?

Updated templates to use 2.3.*

@oneolddev oneolddev changed the title Update FetchData.razor to remove nullable warnings Template updates Jun 12, 2023
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 12, 2023

Yes, I'll do that after merge. Need to build a new package anyways

@vnbaaij vnbaaij merged commit bee3536 into microsoft:main Jun 12, 2023
@oneolddev oneolddev deleted the patch-2 branch October 4, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants