Fix #370 - FluentIcon performance improvements #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduced number of StaticAssetService.GetAsync calls in FluentIcon - suppression of re-render if parameters haven't changed (when icon is in RenderFragment) - dedicated dictionary instead of array is used for icon availability check
|
@microsoft-github-policy-service agree |
vnbaaij
approved these changes
Jun 7, 2023
src/Microsoft.Fast.Components.FluentUI/Components/Icon/FluentIcon.cs
Outdated
Show resolved
Hide resolved
|
Could you change the PR name (more explicit than "Fix #370") ? :-) |
andreisaperski
changed the title
dvoituron
reviewed
Jun 8, 2023
src/Microsoft.Fast.Components.FluentUI/Components/Icon/FluentIcon.cs
Outdated
Show resolved
Hide resolved
dvoituron
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
🎫 Issues
#370
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps