Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 6 #433

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Patch 6 #433

merged 4 commits into from
Jun 5, 2023

Conversation

Ogglas
Copy link
Contributor

@Ogglas Ogglas commented Jun 5, 2023

Pull Request

📖 Description

Added example from the discussion in #394. Got a culture error when running locally (Swedish culture) and therefore added CultureInfo.InvariantCulture for Parse methods.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@vnbaaij vnbaaij merged commit 2c0c34f into microsoft:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants