Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DialogHeader] Allow dialog title exclusion from tab index #3137

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

NataschaZorgWijnhoven
Copy link
Contributor

@NataschaZorgWijnhoven NataschaZorgWijnhoven commented Jan 8, 2025

Pull Request

📖 Description

No possibility to exclude the dialog title from the tab index. The FluentDialogHeader provides a default tabindex of 0 which could not be overwritten.
Repro:
Recording 2025-01-08 120848

Now it is possible to adjust the tabindex by means of the new parameter TabIndex. In case you also do not wish to not see the dismiss tooltip, you can set the new parameter ShowDismissTooltip to "false".
Repro:
Recording 2025-01-10 105014

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@NataschaZorgWijnhoven
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Quadira"

Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tabindex=“0" attribute is present to avoid displaying the ’Close” tooltip when the dialog box is open. You can see this in your second example.

src/Core/Components/Dialog/FluentDialogHeader.razor.cs Outdated Show resolved Hide resolved
@vnbaaij
Copy link
Collaborator

vnbaaij commented Jan 9, 2025

@NataschaZorgWijnhoven I'm seeing build errors in the pipelines (not finding CssBuilder/StyleBuilder). Can you check locally and correct?

@NataschaZorgWijnhoven
Copy link
Contributor Author

@NataschaZorgWijnhoven I'm seeing build errors in the pipelines (not finding CssBuilder/StyleBuilder). Can you check locally and correct?

The build errors have now been fixed.

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jan 10, 2025

@NataschaZorgWijnhoven just one more request...can you update the PR description to the latest state of what has actually been done (ie no more ExcludeFromTabFocus but now ShowDismissTooltip and TabIndex).

Build here on GH has indeed concluded successfully now so updating the description is the last thing before we can merge

@NataschaZorgWijnhoven
Copy link
Contributor Author

@NataschaZorgWijnhoven just one more request...can you update the PR description to the latest state of what has actually been done (ie no more ExcludeFromTabFocus but now ShowDismissTooltip and TabIndex).

Build here on GH has indeed concluded successfully now so updating the description is the last thing before we can merge

Good call. I have adjusted it to reflect the current implementation.

@vnbaaij vnbaaij merged commit 3e22958 into microsoft:dev Jan 10, 2025
4 checks passed
@vnbaaij vnbaaij added this to the v4.11.1 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants