-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DialogHeader] Allow dialog title exclusion from tab index #3137
Conversation
@microsoft-github-policy-service agree company="Quadira" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tabindex=“0"
attribute is present to avoid displaying the ’Close” tooltip when the dialog box is open. You can see this in your second example.
@NataschaZorgWijnhoven I'm seeing build errors in the pipelines (not finding |
The build errors have now been fixed. |
@NataschaZorgWijnhoven just one more request...can you update the PR description to the latest state of what has actually been done (ie no more ExcludeFromTabFocus but now ShowDismissTooltip and TabIndex). Build here on GH has indeed concluded successfully now so updating the description is the last thing before we can merge |
Good call. I have adjusted it to reflect the current implementation. |
Pull Request
📖 Description
No possibility to exclude the dialog title from the tab index. The FluentDialogHeader provides a default tabindex of 0 which could not be overwritten.
Repro:
Now it is possible to adjust the tabindex by means of the new parameter TabIndex. In case you also do not wish to not see the dismiss tooltip, you can set the new parameter ShowDismissTooltip to "false".
Repro:
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps