[DataGrid] Respecting control state of Loading parameter #3064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
π« Issues
Fixes #2998
π©βπ» Reviewer Notes
This PR changes
FluentDataGrid.Loading
to a nullable boolean. If the value is not-null, the grid is considered controlled and requires the user to change loading state themselves. If the value is null, the grid will manage loading state itself - ifItems
are provided, Loading is set to false, otherwise Loading is true until theItemsProvider
has returned data.This also fixes the issue where initially
EmptyContent
is rendered if there is an ItemsProvider when the grid should be renderingLoadingContent
.As a smoke test, you can look at the "Remote Data" section on the DataGrid demo example page, which now shows a loading page before content is loaded.
π Test Plan
I've added a basic DataGrid test as well as several tests surrounding Loading, with either ItemsProvider or Items.
β Checklist
General
Component-specific
β Next Steps