Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MessageBar] Update way animation is applied to the MessageBar #2723

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

yspanj
Copy link
Contributor

@yspanj yspanj commented Sep 26, 2024

Pull Request

πŸ“– Description

Updated the was the animation is applied to the MessageBar component.
As discussed in #2716

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@yspanj yspanj changed the title Update way animation is appliedto the MessageBar Update way animation is applied to the MessageBar Sep 26, 2024
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test for the 'null'-variant as well? (working from my phone)

@yspanj
Copy link
Contributor Author

yspanj commented Sep 26, 2024

Do we have a test for the 'null'-variant as well? (working from my phone)

That should be covered by the FluentMessageBar_DisableFadeIn() test case added in the previous pull request.
But since the animation attribute isn't rendered the test didn't need to be updated for this change.

@yspanj yspanj changed the title Update way animation is applied to the MessageBar [MessageBar] Update way animation is applied to the MessageBar Sep 26, 2024
@vnbaaij vnbaaij merged commit 199cf6c into microsoft:dev Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants