Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuButton] Add an optional start icon #2707

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

adtaylor-cs
Copy link
Contributor

Pull Request

πŸ“– Description

This is a small PR to add the ability to add an icon to the start of a FluentMenuButton.

🎫 Issues

N/A

πŸ‘©β€πŸ’» Reviewer Notes

This is a pretty small change, and I've added an example to the Demo site. The result is as seen in this screenshot:

image

πŸ“‘ Test Plan

Added to the existing FluentMenuButton unit test.

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

N/A

@vnbaaij vnbaaij changed the title Add an optional start icon for the FluentMenuButton [MenuButton] Add an optional start icon Sep 24, 2024
@vnbaaij vnbaaij added this to the v4.10.1 milestone Sep 25, 2024
@vnbaaij vnbaaij merged commit 8d2c0b2 into microsoft:dev Sep 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants