-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix Autocomplete Aria-Hidden and Focusable #2648
Merged
vnbaaij
merged 4 commits into
dev
from
users/dvoituron/fix-autocomplete-ariahidden-focusable
Sep 12, 2024
Merged
[Autocomplete] Fix Autocomplete Aria-Hidden and Focusable #2648
vnbaaij
merged 4 commits into
dev
from
users/dvoituron/fix-autocomplete-ariahidden-focusable
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/fix-autocomplete-ariahidden-focusable
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.1%
|
vnbaaij
approved these changes
Sep 12, 2024
vnbaaij
deleted the
users/dvoituron/fix-autocomplete-ariahidden-focusable
branch
September 12, 2024 14:46
dannyldj
pushed a commit
to dannyldj/fluentui-blazor
that referenced
this pull request
Sep 26, 2024
…2648) * Fix Autocomplete Aria-Hidden and Focusable * Update the actions/upload-artifact to v4 --------- Co-authored-by: Vincent Baaij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Autocomplete] Fix Autocomplete Aria-Hidden and Focusable
When focus is placed on a
FluentIcon
(e.g. the Dimiss icon), this error occurs:See #2644
A test was added to remove
aria-hidden
when theFocusable
property is True.Unit Tests
Updated