[DataGrid] Provide new way to render column actions #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61%
|
dvoituron
requested changes
Aug 27, 2024
Yes. I was experimenting with some settings. Changing that back to default which will get you: |
dvoituron
approved these changes
Aug 27, 2024
dannyldj
pushed a commit
to dannyldj/fluentui-blazor
that referenced
this pull request
Sep 26, 2024
* Store progress * Use records for string parameter collections * Tabbing error 🤦♂️ * Move and change column 'label resources' records * Process PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this new behavior is 'opt-in' and can be enabled by adding
HeaderCellAsButtonWithMenu="true"in your data grid component tag.Following the work that was done in Aspire, we are adding a new way to render column actions (sort, resize and options (filter)) by using a menu shown when clicking on a column header:
As can be seen in the image, the current sort direction is displayed on the menu item. The sort direction and filter state are shown on the header with icons.
Which items are displayed on a menu is dependent on the parameter settings on the grid. So when a column is not sortable, its menu won't show the 'Sort' menu item. If there is also no column options/filter specified, it will directly show the Resize UI (in this case because
ResizeType.Discretehas been set on the grid):When a DataGrid is not resizable and a column does not have any options ui (no filter) applied, the header button still functions as a sort button directly:
The 'Bronze' column is not sortable and therefore shows a disabled cursor (not shown in the screengrab)
This PR also contains changes discussed in PR #2585. There a now records for resize, sort and options which use default values when a developer does not make any changes.
DataGridTypical.razorcontains an example of how the labels can be changed.