-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoComplete] Allow focusable Badge dismiss buttons (accessibility) #2272
Merged
dvoituron
merged 3 commits into
dev
from
users/dvoituron/autocomplete-add-focus-remove-item
Jun 26, 2024
Merged
[AutoComplete] Allow focusable Badge dismiss buttons (accessibility) #2272
dvoituron
merged 3 commits into
dev
from
users/dvoituron/autocomplete-add-focus-remove-item
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 60.4%
|
vnbaaij
approved these changes
Jun 26, 2024
vnbaaij
changed the title
[FluentAutocomplete] Accessibility - Allow focusable Badge dismiss buttons
[AutoComplete] Allow focusable Badge dismiss buttons (accessibility)
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FluentAutocomplete] Accessibility - Allow focusable Badge dismiss buttons
At the request of the Accessibility team, the Dismiss buttons on the selected elements must be focusable.
To achieve this, we need to add a
Focusable
property to theFluentIcon
component, which is itself used by theFluentBadge
component.Demo (with sound)
Autocomplete-dismiss.mp4
Unit Tests
Updates