Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] Add null check for empty string #2245

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

MarvinKlein1508
Copy link
Contributor

Pull Request

📖 Description

This PR adds a null check for the FluentTimePicker which converts empty strings to DateTime?.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

I've added a new UNIT Test FluentTimePicker_EmptyStringToNull to verfiy the results.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@MarvinKlein1508
Copy link
Contributor Author

@dvoituron should be good now :)

@vnbaaij vnbaaij changed the title [FluentTimePicker] Add null check for empty string [TimePicker] Add null check for empty string Jun 24, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) June 24, 2024 13:12
@vnbaaij vnbaaij merged commit 119657d into microsoft:dev Jun 24, 2024
2 checks passed
@vnbaaij vnbaaij added this to the v4.8.2 milestone Jun 25, 2024
@MarvinKlein1508 MarvinKlein1508 deleted the fix-2230 branch June 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants