Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo ] Add DataGridTableScroll demo #2098

Merged
merged 2 commits into from
May 26, 2024
Merged

[Demo ] Add DataGridTableScroll demo #2098

merged 2 commits into from
May 26, 2024

Conversation

MarvinKlein1508
Copy link
Contributor

@MarvinKlein1508 MarvinKlein1508 commented May 26, 2024

Pull Request

📖 Description

Added new DataGrid demo to show how to use "Table mode" on FluentDataGrid based on discussion #57820

fluentdatagrid-mobile

@dvoituron
Copy link
Collaborator

Could you add a screenshot in the PR description to simplify the future Release note?

@MarvinKlein1508
Copy link
Contributor Author

@dvoituron I would but the app doesn't compile for me:

 build
1>> node ./esbuild.config.mjs
1>
1>file:///G:/Programmierung/fluentui-blazor/src/Core.Assets/esbuild.config.mjs:2
1>import pkg from './package.json' assert { type: 'json' }
1>                                 ^^^^^^
1>
1>SyntaxError: Unexpected identifier 'assert'
1>    at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
1>    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:163:18)
1>    at callTranslator (node:internal/modules/esm/loader:430:14)
1>    at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:436:30)
1>    at async ModuleJob._link (node:internal/modules/esm/module_job:106:19)
1>
1>Node.js v22.2.0

I think I might have the wrong version of node. But couldn't find any info in the repo what I need to install for it.

@dvoituron
Copy link
Collaborator

Weird. This Node version seems enough. Are you using VS 2022 Preview? Or could tou run ˋnpm install` from the Assets project folder ?

@MarvinKlein1508
Copy link
Contributor Author

@dvoituron I'm using VS 17.10.0

grafik

@dvoituron
Copy link
Collaborator

I'm also using this VS and Node 20.10.0 with the same npm fund result.

Microsoft Visual Studio Professional 2022 (64-bit) - Preview
Version 17.10.0 Preview 7.0

The problem is probably elsewhere :-(

@MarvinKlein1508
Copy link
Contributor Author

@dvoituron it is the nodeJS version. Downgrading to your version works fine for me. Here you go:
fluentdatagrid-desktop

fluentdatagrid-mobile

@vnbaaij vnbaaij changed the title Add DataGridTableScroll demo #57820 [Demo ] Add DataGridTableScroll demo May 26, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) May 26, 2024 15:45
@MarvinKlein1508
Copy link
Contributor Author

@microsoft-github-policy-service agree

@vnbaaij vnbaaij merged commit 9323d7d into microsoft:dev May 26, 2024
2 checks passed
@MarvinKlein1508 MarvinKlein1508 deleted the docs-update branch May 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants