[NavMenu] Fix keyboard navigation #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnbaaij
approved these changes
Apr 26, 2024
vnbaaij
changed the title
vnbaaij
added a commit
that referenced
this pull request
Apr 29, 2024
* [FluentNavMenu] Fix keyboard navigation * [FluentNavMenu] Fix tests --------- Co-authored-by: Alessio Dell Aquila <[email protected]> Co-authored-by: Vincent Baaij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Based on PR #1730, this PR fixes keyboard navigation in the
FluentNavMenucomponent.The nav menu can be opened and closed with keys again when collapsible.
Disabled
FluentNavMenuGroups andFluentNavMenuItems can't be focused using keyboard navigation anymore.📑 Test Plan
The
FluentNavGroup_Disabledtest was affected by this PR as it seems to have allowed focusing a disabled nav menu group.✅ Checklist
General
Component-specific