Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppBar] Apply role requirements #1871

Merged
merged 3 commits into from
Apr 17, 2024
Merged

[AppBar] Apply role requirements #1871

merged 3 commits into from
Apr 17, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Apr 16, 2024

Fixing dotnet/aspire#3397 by applying role="navigation" for AppBar and removing any roles for AppBarItems
Fix #1864

@vnbaaij vnbaaij added the a11y Accessibillity label Apr 16, 2024
@vnbaaij vnbaaij added this to the v4.6.2 milestone Apr 16, 2024
@vnbaaij vnbaaij self-assigned this Apr 16, 2024
@vnbaaij vnbaaij requested a review from dvoituron as a code owner April 16, 2024 12:34
@vnbaaij vnbaaij merged commit b3ac3cd into dev Apr 17, 2024
1 of 2 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/fix-issue-#1864 branch April 17, 2024 07:40
@vnbaaij vnbaaij modified the milestones: v4.6.2, v4.7.0 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibillity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: AppBar component uses incorrect roles for nav element and links
2 participants