[Docs] Update KeyCodeGlobalExample.razor.css to fix dark mode visuals #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key text was hard to read in dark mode, changed CSS so text looks good in both modes.
digitaldirk
changed the title
vnbaaij
approved these changes
Apr 11, 2024
vnbaaij
added a commit
that referenced
this pull request
Apr 29, 2024
The key text was hard to read in dark mode, changed CSS so text looks good in both modes. Co-authored-by: Vincent Baaij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key text was hard to read in dark mode, changed CSS so text looks good in both modes.
Pull Request
📖 Description
Just made text color black so the key text was more readable in both modes.
Before:
(Hard to read)
After:
🎫 Issues
👩💻 Reviewer Notes
Visually tested. open to other solutions.
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps