Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PullToRefresh] New component PullToRefresh #1679

Merged
merged 21 commits into from
Mar 25, 2024
Merged

[PullToRefresh] New component PullToRefresh #1679

merged 21 commits into from
Mar 25, 2024

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Mar 12, 2024 •
edited
Loading

Add a PullToRefresh component. Height of the pull tip can be specified as well as template paramters are provided for the different pull tip states.

pulltorefresh

@vnbaaij
Intial adding of component
040650e
@vnbaaij
- Consolidate PullUp and PullDown in one compoent
5a010f7 
- Add examples
@vnbaaij
- Remove iframes
a5f668b 
- Use fluent names and tokens in razor and CSS
- Reorg class file
@vnbaaij vnbaaij self-assigned this Mar 12, 2024
@dvoituron
Copy link
Collaborator

Great job :-)

Few comments:

  • An explanation must be included before the vant-touch-emulator.js to explain that this file is only there to add compatibility with all browsers. It's not needed for the components.
  • By default, the "Pull down to refresh" section must be hidden and only LoadingTip is shown. But that might be restrictive to have all the other Tips for other cases.
  • I would rename OnRefreshing to OnRefresh (like you have ontouchstart or OnParametersSet.
  • I would rename PullingTip, WaitingTip, LoadingTip, CompletedTip and NoDataTip to PullingTemplate (like other components)
  • I would rename OnTouchStart to OnTouchStartAsync to be consistent with other similar methods.
  • I would replace the content of LoadingTip with a Progress Ring.

@vnbaaij vnbaaij changed the title Add PullToRefresh [WIP] [PullToRefresh] New component PullToRefresh Mar 19, 2024
@vnbaaij
- Fix pull up logic.
22440d1 
- Add parameter to set tip height
- Show example with progress bar instead of ring
@vnbaaij vnbaaij marked this pull request as ready for review March 19, 2024 12:29
@vnbaaij vnbaaij requested a review from dvoituron March 19, 2024 12:30
@vnbaaij vnbaaij enabled auto-merge (squash) March 19, 2024 12:30
@vnbaaij vnbaaij requested a review from dvoituron March 24, 2024 10:25
@vnbaaij vnbaaij disabled auto-merge March 25, 2024 20:33
@vnbaaij vnbaaij merged commit 9d3655a into dev Mar 25, 2024
3 checks passed
@vnbaaij vnbaaij deleted the users/vnbaaij/pull-to-refresh branch March 25, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoituron dvoituron dvoituron approved these changes

Assignees

@vnbaaij vnbaaij

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnbaaij @dvoituron