-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add global search bar #1583
Conversation
@Hona please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
Thanks @dvoituron :) I've actioned all your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
@Hona It's a pity that the search component doesn't work with keyboard arrows. This is a problem for our Accessibility rules. Would it be possible to make another PR and replace it with a FluentAutocomplete, for example? We'll have to see beforehand if it works in the same way :-) |
Ah, that is a shame. I can take a look today at switching it over. Is the accessibility problem an underlying issue with the fluent components or the blazor wrapper? |
Probably because you used a FluentSearch and a FluentMenu. And pressing Down/Up keys don't select an Items. The FluentAutocomplete do that. |
* feat: Add global search bar * fix: warning * refactor: Code review comments * refactor: Move injected services to code behind * refactor: formatting --------- Co-authored-by: Vincent Baaij <[email protected]>
Pull Request
📖 Description
from
to
Example when typing valid content:
Note: Hides on mobile - future work could make it nice & responsive. Probably an Icon only button that pops up a fullscreen overlay
🎫 Issues
Fixes #1578
👩💻 Reviewer Notes
📑 Test Plan
Manually test the nav menu looks the same (I tested each item 1 by 1 & saw no difference).
Test that the search bar behaves as a nice UX.
✅ Checklist
General
- [ ] I have added tests for my changes.Not done - No tests in Demo site