Small performance update for rendering list items #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
requested changes
Feb 8, 2024
tests/TemplateValidation/NoAuthentication/B-Server/Global/Components/Pages/Home.razor
Outdated
Show resolved
Hide resolved
| if (prop is not null) | ||
| { | ||
| (Icon Value, Color? Color, string? Slot) = ((Icon Value, Color? Color, string? Slot)) prop.GetValue(item)!; | ||
| (Icon Value, Color? Color, string? Slot) = ((Icon Value, Color? Color, string? Slot))prop.GetValue(item)!; |
There was a problem hiding this comment.
To validate, but if your Option<TType> class implements this interface, you could cast your object and have access to these properties:
var optionIcon = item as IOptionIcon;
var value = optionIcon?.Icon.Value;
...internal interface IOptionIcon
{
(Icon Value, Color? Color, string? Slot) Icon { get; set; }
}
dvoituron
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a type check (using reflection) on each item in the list of items (if supplied), only do this for the first item in the list.