Better fix for #1205 / #1225 which fixes #1294 #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1306.westeurope.3.azurestaticapps.net |
dvoituron
requested changes
Jan 11, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1306.westeurope.3.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1306.westeurope.3.azurestaticapps.net |
dvoituron
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With earlier fixes, we made it possible to have submit button be outside of
EditForm. This requires to have anidset on theEditForm. However, theidwas now also required when the submit was placed inside theEditForm. This PR fixes that. It will also show a warning now in the browser console when submit is placed outside ofEditFormand noidis supplied.