Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1194 #v3 #1222

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Fix #1194 #v3 #1222

merged 4 commits into from
Dec 28, 2023

Conversation

vnbaaij
Copy link
Collaborator

@vnbaaij vnbaaij commented Dec 27, 2023

When HandleOnTabChange is being called with TabChangeEventArgs being null, the component should not rerender itself (as no actual tab change has taken place)
In troduced a bool _shouldRender which is set to false when the above happens. The overridden ShouldRender base method now returns the value of _shouldRender and effectively cancels the re-render whna no tab change has occured.

@vnbaaij vnbaaij requested a review from dvoituron December 27, 2023 12:14
@vnbaaij vnbaaij enabled auto-merge (squash) December 27, 2023 12:14
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1222.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1222.westeurope.3.azurestaticapps.net

1 similar comment
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1222.westeurope.3.azurestaticapps.net

@vnbaaij vnbaaij disabled auto-merge December 28, 2023 07:57
@vnbaaij vnbaaij merged commit 5111780 into dev Dec 28, 2023
3 checks passed
@vnbaaij vnbaaij deleted the vnbaaij/fix-1194 branch December 28, 2023 07:57
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1222.westeurope.3.azurestaticapps.net

vnbaaij added a commit that referenced this pull request Dec 28, 2023
* Fix #1194 #v3

* Add _shouldRender =true to if to be on the safe side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant