Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppBar missing some top padding on the popover for smaller views #1973

Closed
StephenOTT opened this issue Apr 29, 2024 · 0 comments · Fixed by #1976
Closed

fix: AppBar missing some top padding on the popover for smaller views #1973

StephenOTT opened this issue Apr 29, 2024 · 0 comments · Fixed by #1976
Labels
triage New issue. Needs to be looked at

Comments

@StephenOTT
Copy link

🐛 Bug Report

If you load app bar in place of the traditional nav menu and go to XS sizes you get:

image

The top of the window is cut off.

💻 Repro or Code Sample

Where traditional navMenu would be placed:

                <FluentStack Class="main" Orientation="Orientation.Horizontal" Width="100%" HorizontalGap="2">
                    @* <NavMenu/> *@

                    <FluentStack Orientation="Orientation.Vertical" HorizontalAlignment="HorizontalAlignment.Center" Width="70px">
                        <FluentAppBar PopoverShowSearch="true" Class="pl-5" Style="height: 100%; max-height: 70dvh">
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                            <FluentAppBarItem IconRest="ResourcesIcon()" IconActive="ResourcesIcon(true)" Text="Some Title"/>
                        </FluentAppBar>
                    </FluentStack>
...

🤔 Expected Behavior

A simple quick fix is to add some top padding to the popover's fluent-anchored-region:

image image

using 4.7.1

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Apr 29, 2024
vnbaaij added a commit that referenced this issue Apr 30, 2024
vnbaaij added a commit that referenced this issue Apr 30, 2024
… status when Href is null or not specified (#1976)

* [AppBar] changes for fixing #1974

* [AppBar] Fix #1973 by addin margin to top

* Process PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issue. Needs to be looked at
Projects
None yet
1 participant